From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Zhao Zhili <zhilizhao@tencent.com>
Subject: Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: fix CODECS attribute of H.264
Date: Mon, 29 May 2023 17:16:43 +0200
Message-ID: <168537340353.3843.1827807266927340280@lain.khirnov.net> (raw)
In-Reply-To: <tencent_9F2D69FE7D7EAD963889C135B4A468B6030A@qq.com>
Quoting Zhao Zhili (2023-05-29 17:08:50)
>
> > 在 2023年5月29日，22:46，Anton Khirnov <anton@khirnov.net> 写道：
> >
> > Quoting Zhao Zhili (2023-05-30 00:16:05)
> >> Subject: Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: fix CODECS attribute of H.264
> >
> > "fix bug" commit message are not very useful
>
> However, CODECS attribute is a particular detail for HLS. Any suggestions to make it more clear and not too verbose?
Keep the first line as is, but add a commit message body that says at
least what the problem was. Possibly also how it's being fixed, if it is
not obvious.
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-05-29 15:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-29 22:16 Zhao Zhili
2023-05-29 14:46 ` Anton Khirnov
2023-05-29 15:08 ` Zhao Zhili
2023-05-29 15:16 ` Anton Khirnov [this message]
2023-06-08 2:45 ` [FFmpeg-devel] [PATCH v2] " Zhao Zhili
2023-06-09 4:58 ` Lance Wang
2023-05-30 1:03 ` [FFmpeg-devel] [PATCH] " Lance Wang
2023-05-30 3:09 ` "zhilizhao(赵志立)"
2023-05-30 4:44 ` Lance Wang
2023-05-30 5:28 ` "zhilizhao(赵志立)"
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168537340353.3843.1827807266927340280@lain.khirnov.net \
--to=anton@khirnov.net \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=zhilizhao@tencent.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git