From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avfilter/af_apad: switch to activate
Date: Sat, 27 May 2023 17:42:56 +0200
Message-ID: <168520217654.3843.9077008342291215511@lain.khirnov.net> (raw)
In-Reply-To: <CAPYw7P4Pg0EkQaoqS8bTV2=oHcFbEBH8Y=i5E2q32wLSKKZdvg@mail.gmail.com>
Quoting Paul B Mahol (2023-05-18 19:48:47)
> Attached.
>
> From c06d3d9f6020fdda19641637cafa6f86c77b4b73 Mon Sep 17 00:00:00 2001
> From: Paul B Mahol <onemda@gmail.com>
> Date: Wed, 17 May 2023 09:14:56 +0200
> Subject: [PATCH 21/27] avfilter/af_apad: switch to activate
>
> Signed-off-by: Paul B Mahol <onemda@gmail.com>
> ---
> libavfilter/af_apad.c | 105 ++++++++++++++++++++++++++++--------------
> 1 file changed, 71 insertions(+), 34 deletions(-)
The commit message for such commits should mention why is this better,
because it is not obvious. For one thing, the new code is significantly
longer.
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-05-27 15:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-18 17:48 Paul B Mahol
2023-05-27 14:03 ` Paul B Mahol
2023-05-27 15:42 ` Anton Khirnov [this message]
2023-05-27 15:46 ` Paul B Mahol
2023-05-27 15:51 ` Paul B Mahol
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168520217654.3843.9077008342291215511@lain.khirnov.net \
--to=anton@khirnov.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git