From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E34A3465D9 for ; Mon, 22 May 2023 16:11:02 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1F67368BF99; Mon, 22 May 2023 19:11:00 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7938C680547 for ; Mon, 22 May 2023 19:10:53 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id EBF252404EC for ; Mon, 22 May 2023 18:10:52 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id HU-rUrYCu4L3 for ; Mon, 22 May 2023 18:10:52 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 35C09240177 for ; Mon, 22 May 2023 18:10:52 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 180C61601B2; Mon, 22 May 2023 18:10:52 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: Mail-Followup-To: FFmpeg development discussions and patches Date: Mon, 22 May 2023 18:10:52 +0200 Message-ID: <168477185206.9711.13647641068983009683@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] avformat/gifdec: cleanup X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting James Almer (2023-05-22 18:07:50) > On 5/22/2023 12:49 PM, Paul B Mahol wrote: > > On 5/21/23, Paul B Mahol wrote: > >> Attached patches. > >> > >> This finally removes giant hacks in gif demuxer and allows using gif > >> files via pipe reliably. > >> > > > > Now with smaller diff. > > [...] > > > From f3d6eea43df686b4211601b194fac81f032eb273 Mon Sep 17 00:00:00 2001 > > From: Paul B Mahol > > Date: Sun, 21 May 2023 02:15:26 +0200 > > Subject: [PATCH 1/2] avformat/demux: add support to derive timestamps from > > packet durations for video > > > > Signed-off-by: Paul B Mahol > > --- > > libavformat/demux.c | 5 +++++ > > 1 file changed, 5 insertions(+) > > > > diff --git a/libavformat/demux.c b/libavformat/demux.c > > index dec02a1a6b..b3f563ccc7 100644 > > --- a/libavformat/demux.c > > +++ b/libavformat/demux.c > > @@ -1195,6 +1195,11 @@ static int parse_packet(AVFormatContext *s, AVPacket *pkt, > > st->time_base, > > AV_ROUND_DOWN); > > } > > + } else if ((s->iformat->flags & AVFMT_NOTIMESTAMPS) && st->codecpar->codec_type == AVMEDIA_TYPE_VIDEO) { > > Why only for AVFMT_NOTIMESTAMPS formats? Same as the audio check above, > the parser could set duration regardless of where the packet came from. I suggested that on IRC. The idea is that container durations are authoritative for video, so parser duration should only be used when we do not have container timing. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".