From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 2F7B4464E0 for ; Sat, 20 May 2023 16:45:43 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 6EDB168C14C; Sat, 20 May 2023 19:45:42 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 11E6A6806D7 for ; Sat, 20 May 2023 19:45:36 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id C92382404EC for ; Sat, 20 May 2023 18:45:35 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id oVOZt4Z2H0Hl for ; Sat, 20 May 2023 18:45:35 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 27636240177 for ; Sat, 20 May 2023 18:45:35 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 15D7B1601B2; Sat, 20 May 2023 18:45:35 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <5b7bff8c-03b6-c110-dd10-6159da79a3e8@gmail.com> References: <20230520132113.1855-1-jamrial@gmail.com> <168459924310.3843.13152123010839777505@lain.khirnov.net> <5b7bff8c-03b6-c110-dd10-6159da79a3e8@gmail.com> Mail-Followup-To: FFmpeg development discussions and patches Date: Sat, 20 May 2023 18:45:35 +0200 Message-ID: <168460113505.3843.12020239738668177718@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] avcodec/libdav1d: only return EAGAIN when there are no buffered packets X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting James Almer (2023-05-20 18:42:11) > On 5/20/2023 1:14 PM, Anton Khirnov wrote: > > Quoting James Almer (2023-05-20 15:21:13) > >> Fixes decoding packets containing split temporal units, as generated for example > >> by the av1_frame_split bsf. > >> > >> Signed-off-by: James Almer > >> --- > >> libavcodec/libdav1d.c | 9 ++++++--- > >> 1 file changed, 6 insertions(+), 3 deletions(-) > >> > >> diff --git a/libavcodec/libdav1d.c b/libavcodec/libdav1d.c > >> index c15e98cbd1..55ea9166b6 100644 > >> --- a/libavcodec/libdav1d.c > >> +++ b/libavcodec/libdav1d.c > >> @@ -328,6 +328,7 @@ static int libdav1d_receive_frame(AVCodecContext *c, AVFrame *frame) > >> #endif > >> int res; > >> > >> +again: > > > > yuck > > I could make it a while loop, but then i need to reindent a lot of > lines. Is a goto that bad? We use that everywhere... I know people use it, but I personally find it very evil. It's making the code significantly less readable (especially when it's further modified in the future) just to avoid restructuring it properly. Future readers will thank you for restructuring it now. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".