From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 157E746428 for ; Thu, 18 May 2023 08:34:40 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 99FF068C116; Thu, 18 May 2023 11:34:37 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 7C3A168BBB1 for ; Thu, 18 May 2023 11:34:30 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 3519A2404EC for ; Thu, 18 May 2023 10:34:30 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id T_g9x1B7haZ5 for ; Thu, 18 May 2023 10:34:29 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id A8540240177 for ; Thu, 18 May 2023 10:34:29 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 921851601B2; Thu, 18 May 2023 10:34:29 +0200 (CEST) From: Anton Khirnov To: Ffmpeg Devel In-Reply-To: References: Mail-Followup-To: Ffmpeg Devel Date: Thu, 18 May 2023 10:34:29 +0200 Message-ID: <168439886956.3843.15772842482127825125@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] libavcodec: add Vulkan common video code X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: > commit 3257feba101053b0b3689147c1a8850f68448f62 > Author: Lynne > Date: Sun Dec 18 08:31:03 2022 +0100 > > libavcodec: add Vulkan common video code > > +static AVBufferRef *alloc_data_buf(void *opaque, size_t size) > +{ > + uint8_t *buf = av_mallocz(size); > + if (!buf) > + return NULL; > + > + return av_buffer_create(buf, size, free_data_buf, opaque, 0); leaks buf on av_buffer_create() failure. > +av_cold int ff_vk_video_common_init(void *log, FFVulkanContext *s, > + FFVkVideoCommon *common, > + VkVideoSessionCreateInfoKHR *session_create) > +{ > + int err; > + VkResult ret; > + FFVulkanFunctions *vk = &s->vkfn; > + VkMemoryRequirements2 *mem_req = NULL; > + VkVideoSessionMemoryRequirementsKHR *mem = NULL; > + VkBindVideoSessionMemoryInfoKHR *bind_mem = NULL; > + > + /* Create session */ > + ret = vk->CreateVideoSessionKHR(s->hwctx->act_dev, session_create, > + s->hwctx->alloc, &common->session); > + if (ret != VK_SUCCESS) > + return AVERROR_EXTERNAL; > + > + /* Get memory requirements */ > + ret = vk->GetVideoSessionMemoryRequirementsKHR(s->hwctx->act_dev, > + common->session, > + &common->nb_mem, > + NULL); > + if (ret != VK_SUCCESS) { > + err = AVERROR_EXTERNAL; > + goto fail; > + } > + > + /* Allocate all memory needed to actually allocate memory */ > + common->mem = av_mallocz(sizeof(*common->mem)*common->nb_mem); av_calloc(), same below -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".