From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id ED6DA46417 for ; Thu, 18 May 2023 06:41:23 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 741F168C121; Thu, 18 May 2023 09:41:20 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 395D468C095 for ; Thu, 18 May 2023 09:41:14 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id F2AB02404EC for ; Thu, 18 May 2023 08:41:13 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id JyUnYzhjgYdo for ; Thu, 18 May 2023 08:41:13 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 58514240177 for ; Thu, 18 May 2023 08:41:13 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 39A321601B2; Thu, 18 May 2023 08:41:13 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20230517200409.GX1391451@pb2> References: <20230517102029.541-1-anton@khirnov.net> <20230517102029.541-31-anton@khirnov.net> <20230517200409.GX1391451@pb2> Mail-Followup-To: FFmpeg development discussions and patches Date: Thu, 18 May 2023 08:41:13 +0200 Message-ID: <168439207319.3843.945623909514887382@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 31/36] fftools/ffmpeg_dec: restructure audio/video decoding loop X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Michael Niedermayer (2023-05-17 22:04:09) > On Wed, May 17, 2023 at 12:20:24PM +0200, Anton Khirnov wrote: > > It currently emulates the long-removed > > avcodec_decode_audio4/avcodec_decode_video2 APIs, which obfuscates the > > actual decoding flow. Restructure the decoding calls so that they > > naturally follow the new avcodec_send_packet()/avcodec_receive_frame() > > design. > > > > This is not only significantly easier to read, but also shorter. > > with this: > ./ffmpeg -y -threads:a 1 -i tickets/1208/702121h264-TTA.mkvtest82.mkv -bitexact -vn file1208.mp3 > > Both before and afterwards the output is empty and we see > > Finishing stream without any data written to it. > Output file is empty, nothing was encoded > > after this patch while the output is not any better, now ffmpeg proclaims > success with its return code > > just to be sure i try reading the output > > [mp3 @ 0x5635bab17900] Format mp3 detected only with low score of 1, misdetection possible! > [mp3 @ 0x5635bab17900] Failed to read frame size: Could not seek to 1026. > [in#0 @ 0x5635bab177c0] Error opening input: Invalid argument > > I dont think that convertion was successfull Your original failure has nothing to do with the output file being empty, as that is not considered an error unless you specify -abort_on empty_output Rather the failure comes from the default maximum error rate of 2/3 being exceeded, since no frame could be decoded successfully. The reason was that the patch did not count avcodec_send_packet() errors into error rate, I've fixed that in a new version. I've also updated the -max_error_rate patch to make the situation clearer. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".