From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6CD0C463B4 for ; Tue, 16 May 2023 14:01:51 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 4179268BEBD; Tue, 16 May 2023 17:01:49 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DA02368BF11 for ; Tue, 16 May 2023 17:01:42 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 8F8922404EC for ; Tue, 16 May 2023 16:01:42 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id s2QRNmADel1a for ; Tue, 16 May 2023 16:01:41 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 507A4240177 for ; Tue, 16 May 2023 16:01:41 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 33C1C1601B2; Tue, 16 May 2023 16:01:41 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20230514213944.GK1391451@pb2> References: <20230514194129.18840-1-anton@khirnov.net> <20230514213944.GK1391451@pb2> Mail-Followup-To: FFmpeg development discussions and patches Date: Tue, 16 May 2023 16:01:41 +0200 Message-ID: <168424570117.3843.2839782071529689850@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] Revert "avformat/hls: fail on probing non hls/m3u8 file extensions" X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Michael Niedermayer (2023-05-14 23:39:44) > On Sun, May 14, 2023 at 09:41:29PM +0200, Anton Khirnov wrote: > > This reverts commit 6b1f68ccb04d791f0250e05687c346a99ff47ea1, which > > broke many streams in the wild > > > > Fixes #10353. > > This change violates a SHOULD in rfc8216 4. Playlists > > Each Playlist file MUST be identifiable either by the path component > of its URI or by HTTP Content-Type. In the first case, the path MUST > end with either .m3u8 or .m3u. In the second, the HTTP Content-Type > MUST be "application/vnd.apple.mpegurl" or "audio/mpegurl". > > Clients SHOULD refuse to parse Playlists that are not so identified. > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > > The commit message should mention the RFC and why it is not following the > recommandition of not parsing such Playlists It's been a longstanding project policy to try to process non-strictly compliant files when possible. And as I've said in the other thread (did not have time yet to reply there, hopefully will soon), I don't think this is the place to enforce such policies. The fact that you have to use NULL logging context is by itself indicative of that. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".