Re: [FFmpeg-devel] [PATCH 55/97] Vulkan patchset part 2 - hwcontext rewrite and filtering

From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 55/97] Vulkan patchset part 2 - hwcontext rewrite and filtering
Date: Tue, 16 May 2023 15:40:47 +0200
Message-ID: <168424444727.3843.5127395344901862629@lain.khirnov.net> (raw)
In-Reply-To: <NVB08ox--3-9@lynne.ee>

Quoting Lynne (2023-05-11 20:13:29)
> >> diff --git a/libavutil/vulkan.h b/libavutil/vulkan.h
> >> index 4bd1c9fc00..4c38dbc2e6 100644
> >> --- a/libavutil/vulkan.h
> >> +++ b/libavutil/vulkan.h
> >> @@ -216,6 +216,9 @@ typedef struct FFVulkanContext {
> >>  VkPhysicalDeviceProperties2 props;
> >>  VkPhysicalDeviceDriverProperties driver_props;
> >>  VkPhysicalDeviceMemoryProperties mprops;
> >> +    VkQueueFamilyQueryResultStatusPropertiesKHR *query_props;
> >> +    VkQueueFamilyVideoPropertiesKHR *video_props;
> >> +    VkQueueFamilyProperties2 *qf_props;
> >>
> >
> > How does the user of these know how many elements are in each array?
> >
> 
> They don't have to, we read the total number of queues available
> for the device, so all indices are always available.

"all indices"?

The allocated size of these arrays is purely local to
ff_vk_load_props(), so there is no safe way for any outside caller to
know it.

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".