From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id B766F463AD for ; Tue, 16 May 2023 13:33:35 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id C001768C021; Tue, 16 May 2023 16:33:33 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 3678468BFB7 for ; Tue, 16 May 2023 16:33:27 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 0148D2404EC for ; Tue, 16 May 2023 15:33:27 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id Rc3a5MD0nppB for ; Tue, 16 May 2023 15:33:26 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 5EDFE240177 for ; Tue, 16 May 2023 15:33:26 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 50CD71601B2; Tue, 16 May 2023 15:33:26 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <168382211746.3843.3110746372135356317@lain.khirnov.net> Mail-Followup-To: FFmpeg development discussions and patches Date: Tue, 16 May 2023 15:33:26 +0200 Message-ID: <168424400630.3843.7231613087858315843@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 55/97] Vulkan patchset part 2 - hwcontext rewrite and filtering X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Lynne (2023-05-11 20:58:38) > May 11, 2023, 18:22 by anton@khirnov.net: > > > Quoting Lynne (2023-04-24 17:56:38) > > > >> From e20962a956444224b34d82f9a5936fae7e43bdf6 Mon Sep 17 00:00:00 2001 > >> From: Lynne > >> Date: Thu, 15 Dec 2022 17:43:27 +0100 > >> Subject: [PATCH 47/97] vulkan: allow alloc pNext in ff_vk_create_buf > >> > >> --- > >> libavutil/vulkan.c | 5 +++-- > >> libavutil/vulkan.h | 3 ++- > >> 2 files changed, 5 insertions(+), 3 deletions(-) > >> > >> diff --git a/libavutil/vulkan.c b/libavutil/vulkan.c > >> index b1553c6537..0bb5b1eebf 100644 > >> --- a/libavutil/vulkan.c > >> +++ b/libavutil/vulkan.c > >> @@ -232,7 +232,8 @@ int ff_vk_alloc_mem(FFVulkanContext *s, VkMemoryRequirements *req, > >> return 0; > >> } > >> > >> -int ff_vk_create_buf(FFVulkanContext *s, FFVkBuffer *buf, size_t size, void *pNext, > >> +int ff_vk_create_buf(FFVulkanContext *s, FFVkBuffer *buf, size_t size, > >> + void *pNext, void *alloc_pNext, > >> VkBufferUsageFlags usage, VkMemoryPropertyFlagBits flags) > >> { > >> int err; > >> @@ -254,7 +255,7 @@ int ff_vk_create_buf(FFVulkanContext *s, FFVkBuffer *buf, size_t size, void *pNe > >> }; > >> VkMemoryDedicatedAllocateInfo ded_alloc = { > >> .sType = VK_STRUCTURE_TYPE_MEMORY_DEDICATED_ALLOCATE_INFO, > >> - .pNext = NULL, > >> + .pNext = alloc_pNext, > >> }; > >> VkMemoryDedicatedRequirements ded_req = { > >> .sType = VK_STRUCTURE_TYPE_MEMORY_DEDICATED_REQUIREMENTS, > >> diff --git a/libavutil/vulkan.h b/libavutil/vulkan.h > >> index 85836a7807..d75be26977 100644 > >> --- a/libavutil/vulkan.h > >> +++ b/libavutil/vulkan.h > >> @@ -413,7 +413,8 @@ int ff_vk_submit_exec_queue(FFVulkanContext *s, FFVkExecContext *e); > >> /** > >> * Create a VkBuffer with the specified parameters. > >> */ > >> -int ff_vk_create_buf(FFVulkanContext *s, FFVkBuffer *buf, size_t size, void *pNext, > >> +int ff_vk_create_buf(FFVulkanContext *s, FFVkBuffer *buf, size_t size, > >> + void *pNext, void *alloc_pNext, > >> VkBufferUsageFlags usage, VkMemoryPropertyFlagBits flags); > >> > > > > Shouldn't you be updating all the callers of this function here? > > > > All callers of the function were in filters in libavfilter, and I wanted to keep all > filter commits in libavfilter separate. Every commit must be buildable on its own. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".