From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 1E63E462CE
	for <ffmpegdev@gitmailbox.com>; Thu, 11 May 2023 17:27:16 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9EACD68C154;
	Thu, 11 May 2023 20:27:14 +0300 (EEST)
Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E9BBA68C042
 for <ffmpeg-devel@ffmpeg.org>; Thu, 11 May 2023 20:27:08 +0300 (EEST)
Received: from localhost (localhost [IPv6:::1])
 by mail0.khirnov.net (Postfix) with ESMTP id 8F9A02404EC
 for <ffmpeg-devel@ffmpeg.org>; Thu, 11 May 2023 19:27:08 +0200 (CEST)
Received: from mail0.khirnov.net ([IPv6:::1])
 by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024)
 with ESMTP id f4HtOP7_-YvD for <ffmpeg-devel@ffmpeg.org>;
 Thu, 11 May 2023 19:27:08 +0200 (CEST)
Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256
 client-signature RSA-PSS (2048 bits) client-digest SHA256)
 (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK))
 by mail0.khirnov.net (Postfix) with ESMTPS id 0FE84240177
 for <ffmpeg-devel@ffmpeg.org>; Thu, 11 May 2023 19:27:08 +0200 (CEST)
Received: by lain.khirnov.net (Postfix, from userid 1000)
 id F30E51601B2; Thu, 11 May 2023 19:27:07 +0200 (CEST)
From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
In-Reply-To: <NVAp4JL--F-9@lynne.ee>
References: <NTnyn9K--3-9@lynne.ee>
 <168382320471.3843.5279960795904250065@lain.khirnov.net>
 <NVAp4JL--F-9@lynne.ee>
Mail-Followup-To: FFmpeg development discussions and patches
 <ffmpeg-devel@ffmpeg.org>
Date: Thu, 11 May 2023 19:27:07 +0200
Message-ID: <168382602795.3843.9923140146921278092@lain.khirnov.net>
User-Agent: alot/0.8.1
MIME-Version: 1.0
Subject: Re: [FFmpeg-devel] [PATCH 55/97] Vulkan patchset part 2 - hwcontext
 rewrite and filtering
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/168382602795.3843.9923140146921278092@lain.khirnov.net/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

Quoting Lynne (2023-05-11 19:20:45)
> May 11, 2023, 18:40 by anton@khirnov.net:
> 
> > Quoting Lynne (2023-04-24 17:56:38)
> >
> >> @@ -3685,8 +3547,9 @@ static int vulkan_map_from(AVHWFramesContext *hwfc, AVFrame *dst,
> >>  #endif
> >>  #endif
> >>  default:
> >> -        return vulkan_map_frame_to_mem(hwfc, dst, src, flags);
> >> +        break;
> >>
> >
> > This seems like it's also removing the ability to map to memory at all.
> >
> 
> It is. Due to the driver deciding the layout of multiplane images
> (which are used by default), it's not spec-valid to map the memory
> used. Rather than keeping complicated code which receives no
> use at all, I decided to remove it.

That should be stated more clearly in the commit message then, along
with the reason for dropping it.

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".