From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 740C2462C9 for ; Thu, 11 May 2023 17:20:07 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D494868C126; Thu, 11 May 2023 20:20:04 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C9FF868BE6F for ; Thu, 11 May 2023 20:19:58 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 811862404EC for ; Thu, 11 May 2023 19:19:58 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id Q8v0RJETIGVY for ; Thu, 11 May 2023 19:19:57 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id DE0FC240177 for ; Thu, 11 May 2023 19:19:57 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id C99B11601B2; Thu, 11 May 2023 19:19:57 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <168382284239.3843.13031777614998916153@lain.khirnov.net> Mail-Followup-To: FFmpeg development discussions and patches Date: Thu, 11 May 2023 19:19:57 +0200 Message-ID: <168382559778.3843.1665934226550691799@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 55/97] Vulkan patchset part 2 - hwcontext rewrite and filtering X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Lynne (2023-05-11 19:12:56) > May 11, 2023, 18:34 by anton@khirnov.net: > > > Quoting Lynne (2023-04-24 17:56:38) > > > >> From 6b5301aa29b63b90d04505c9386822b2e207a038 Mon Sep 17 00:00:00 2001 > >> From: Lynne > >> Date: Thu, 29 Dec 2022 21:16:21 +0100 > >> Subject: [PATCH 55/97] vulkan: rewrite to support all necessary features > >> > >> --- > >> libavutil/vulkan.c | 2145 ++++++++++++++++++---------------- > >> libavutil/vulkan.h | 515 ++++---- > >> libavutil/vulkan_functions.h | 1 + > >> 3 files changed, 1344 insertions(+), 1317 deletions(-) > >> > > > > lol > > > > We stopped doing development like this 15 years ago. > > > > First, I'm criticized for having too many patches. Now, I'm criticized for > having too few. There's no winning. I have no issue with too many patches - my work on ffmpeg CLI is over 200 commits this year alone. Small patches are reviewable, this horrorshow is not. > This touches EVERYTHING, and so it's titled appropriately. If you dislike > the word in the commit message, I can change it to something with > more marketing impact. No, I dislike the fact that there's a giant uberpatch that rewrites everything with zero explanation or justification. Ideally, it should be a series of small individually reviewable changes. If that is for some reason not feasible, the commit message should contain * good justification for why it is not feasible * detailed explanation on what exactly is being done and why -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".