From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 61D0A462AD for ; Thu, 11 May 2023 17:13:37 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 165CF68C126; Thu, 11 May 2023 20:13:36 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 338C46898AA for ; Thu, 11 May 2023 20:13:30 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id EDE972404EC for ; Thu, 11 May 2023 19:13:29 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id L5NyDDa1TiXX for ; Thu, 11 May 2023 19:13:29 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 246EA240177 for ; Thu, 11 May 2023 19:13:29 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 1389B1601B2; Thu, 11 May 2023 19:13:29 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <168382165941.3843.16293402618072713975@lain.khirnov.net> Mail-Followup-To: FFmpeg development discussions and patches Date: Thu, 11 May 2023 19:13:29 +0200 Message-ID: <168382520904.3843.1081744409957116242@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 55/97] Vulkan patchset part 2 - hwcontext rewrite and filtering X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Lynne (2023-05-11 18:47:46) > May 11, 2023, 18:14 by anton@khirnov.net: > > > Quoting Lynne (2023-04-24 17:56:38) > > > >> From 956f043e9f233675856336e028cc8ee7e35c71f5 Mon Sep 17 00:00:00 2001 > >> From: Lynne > >> Date: Wed, 23 Nov 2022 14:04:28 +0100 > >> Subject: [PATCH 38/97] vulkan: lock queues before submitting operations > >> > >> --- > >> libavutil/vulkan.c | 7 +++++++ > >> 1 file changed, 7 insertions(+) > >> > >> diff --git a/libavutil/vulkan.c b/libavutil/vulkan.c > >> index 6bf2c214b7..ad13b8f3cb 100644 > >> --- a/libavutil/vulkan.c > >> +++ b/libavutil/vulkan.c > >> @@ -625,7 +625,14 @@ int ff_vk_submit_exec_queue(FFVulkanContext *s, FFVkExecContext *e) > >> return AVERROR_EXTERNAL; > >> } > >> > >> + s->hwctx->lock_queue((AVHWDeviceContext *)s->device_ref->data, > >> + e->qf->queue_family, e->qf->cur_queue % e->qf->actual_queues); > >> + > >> ret = vk->QueueSubmit(q->queue, 1, &s_info, q->fence); > >> + > >> + s->hwctx->unlock_queue((AVHWDeviceContext *)s->device_ref->data, > >> + e->qf->queue_family, e->qf->cur_queue % e->qf->actual_queues); > >> + > >> > > > > Should this patch be right after the one that adds these functions? > > > > Yes. The patch before added support for them to the hwcontext. > This patch uses them in vulkan.c, which, at the given position in > the patchset is still an independent component only used for lavfi. > I can squash them, but I'd prefer not to, though no strong feelings > about it. I'm not asking you to squash it, I'm asking you to reorder it so that it immediately follows the patch that adds the locking functions, and isn't ordered 12 patches later for no apparent reason. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".