From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C7FAF462AD for ; Thu, 11 May 2023 17:00:28 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AD45A68BD35; Thu, 11 May 2023 20:00:27 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 9D26D6805B4 for ; Thu, 11 May 2023 20:00:21 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 5FD7D2404EC for ; Thu, 11 May 2023 19:00:21 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id nQborZsl3F9p for ; Thu, 11 May 2023 19:00:20 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id CF2A4240177 for ; Thu, 11 May 2023 19:00:20 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id C0F9B1601B2; Thu, 11 May 2023 19:00:20 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <168382112350.3843.13088494193687499573@lain.khirnov.net> Mail-Followup-To: FFmpeg development discussions and patches Date: Thu, 11 May 2023 19:00:20 +0200 Message-ID: <168382442076.3843.17363651096249384750@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 55/97] Vulkan patchset part 2 - hwcontext rewrite and filtering X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Lynne (2023-05-11 18:40:54) > May 11, 2023, 18:05 by anton@khirnov.net: > > > Quoting Lynne (2023-04-24 17:56:38) > > > >> From c50347a552f5c7c2e3fcf20ef9a1ad4f1a419918 Mon Sep 17 00:00:00 2001 > >> From: Lynne > >> Date: Wed, 23 Nov 2022 20:32:49 +0100 > >> Subject: [PATCH 27/97] hwcontext_vulkan: remove contiguous memory hack > >> > > > > This needs a lot more context. > > > > What was the hack, why was it added, why is it being removed and what > > will be affected by that. > > > > The hack was added to enable exporting of vulkan images to DRM. > On Intel hardware, specifically for DRM images, all planes must be > allocated next to each other, due to hardware limitation, so the hack > used a single large allocation and suballocated all planes from it. > > By natively supporting multiplane images, the driver is what decides > the layout, so exporting just works. > > It's a hack because it conflicted heavily with image allocation, and > with the whole ecosystem in general, before multiplane images were > supported, which just made it redundant. > > This is also the commit which broke the hwcontext hardest and prompted > the entire rewrite in the first place. So take this paragraph and put it in the commit message. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".