Re: [FFmpeg-devel] [PATCH 55/97] Vulkan patchset part 2 - hwcontext rewrite and filtering

[Anton Khirnov <anton@khirnov.net>]

Quoting Lynne (2023-05-11 18:40:54)
> May 11, 2023, 18:05 by anton@khirnov.net:
> 
> > Quoting Lynne (2023-04-24 17:56:38)
> >
> >> From c50347a552f5c7c2e3fcf20ef9a1ad4f1a419918 Mon Sep 17 00:00:00 2001
> >> From: Lynne <dev@lynne.ee>
> >> Date: Wed, 23 Nov 2022 20:32:49 +0100
> >> Subject: [PATCH 27/97] hwcontext_vulkan: remove contiguous memory hack
> >>
> >
> > This needs a lot more context.
> >
> > What was the hack, why was it added, why is it being removed and what
> > will be affected by that.
> >
> 
> The hack was added to enable exporting of vulkan images to DRM.
> On Intel hardware, specifically for DRM images, all planes must be
> allocated next to each other, due to hardware limitation, so the hack
> used a single large allocation and suballocated all planes from it.
> 
> By natively supporting multiplane images, the driver is what decides
> the layout, so exporting just works.
> 
> It's a hack because it conflicted heavily with image allocation, and
> with the whole ecosystem in general, before multiplane images were
> supported, which just made it redundant.
> 
> This is also the commit which broke the hwcontext hardest and prompted
> the entire rewrite in the first place.

So take this paragraph and put it in the commit message.

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".