From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 615C24629F for ; Thu, 11 May 2023 16:30:09 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 0737268BEAE; Thu, 11 May 2023 19:30:07 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C21DE68B102 for ; Thu, 11 May 2023 19:29:59 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 7CC652404EC for ; Thu, 11 May 2023 18:29:59 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id d8yEdrvcQjBb for ; Thu, 11 May 2023 18:29:58 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id E0043240177 for ; Thu, 11 May 2023 18:29:58 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id CE7451601B2; Thu, 11 May 2023 18:29:58 +0200 (CEST) From: Anton Khirnov To: Ffmpeg Devel In-Reply-To: References: Mail-Followup-To: Ffmpeg Devel Date: Thu, 11 May 2023 18:29:58 +0200 Message-ID: <168382259881.3843.17606833076993456127@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 55/97] Vulkan patchset part 2 - hwcontext rewrite and filtering X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Lynne (2023-04-24 17:56:38) > From 786a7d08bc90a88f77057fc31d0943dcb91e4558 Mon Sep 17 00:00:00 2001 > From: Lynne > Date: Thu, 22 Dec 2022 17:37:51 +0100 > Subject: [PATCH 53/97] vulkan: add support for retrieving queue, query and > video properties > > --- > libavutil/vulkan.c | 87 ++++++++++++++++++++++++++++++------ > libavutil/vulkan.h | 14 ++++-- > libavutil/vulkan_functions.h | 1 + > 3 files changed, 85 insertions(+), 17 deletions(-) > > diff --git a/libavutil/vulkan.c b/libavutil/vulkan.c > index de0c300c0e..d045ff83c1 100644 > --- a/libavutil/vulkan.c > +++ b/libavutil/vulkan.c > @@ -108,8 +108,9 @@ const char *ff_vk_ret2str(VkResult res) > #undef CASE > } > > -void ff_vk_load_props(FFVulkanContext *s) > +int ff_vk_load_props(FFVulkanContext *s) > { > + uint32_t qc = 0; > FFVulkanFunctions *vk = &s->vkfn; > > s->driver_props = (VkPhysicalDeviceDriverProperties) { > @@ -120,8 +121,48 @@ void ff_vk_load_props(FFVulkanContext *s) > .pNext = &s->driver_props, > }; > > + > vk->GetPhysicalDeviceProperties2(s->hwctx->phys_dev, &s->props); > vk->GetPhysicalDeviceMemoryProperties(s->hwctx->phys_dev, &s->mprops); > + vk->GetPhysicalDeviceQueueFamilyProperties2(s->hwctx->phys_dev, &qc, s->qf_props); > + > + if (s->qf_props) > + return 0; > + > + s->qf_props = av_mallocz(sizeof(*s->qf_props)*qc); av_calloc() Also, wouldn't it be better to allocate a single array of { qf_props; query_props; video_props; } > diff --git a/libavutil/vulkan.h b/libavutil/vulkan.h > index 4bd1c9fc00..4c38dbc2e6 100644 > --- a/libavutil/vulkan.h > +++ b/libavutil/vulkan.h > @@ -216,6 +216,9 @@ typedef struct FFVulkanContext { > VkPhysicalDeviceProperties2 props; > VkPhysicalDeviceDriverProperties driver_props; > VkPhysicalDeviceMemoryProperties mprops; > + VkQueueFamilyQueryResultStatusPropertiesKHR *query_props; > + VkQueueFamilyVideoPropertiesKHR *video_props; > + VkQueueFamilyProperties2 *qf_props; How does the user of these know how many elements are in each array? -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".