Re: [FFmpeg-devel] [PATCH 55/97] Vulkan patchset part 2 - hwcontext rewrite and filtering

[Anton Khirnov <anton@khirnov.net>]

Quoting Lynne (2023-04-24 17:56:38)
> From c50347a552f5c7c2e3fcf20ef9a1ad4f1a419918 Mon Sep 17 00:00:00 2001
> From: Lynne <dev@lynne.ee>
> Date: Wed, 23 Nov 2022 20:32:49 +0100
> Subject: [PATCH 27/97] hwcontext_vulkan: remove contiguous memory hack
> 

This needs a lot more context.

What was the hack, why was it added, why is it being removed and what
will be affected by that.

> diff --git a/libavutil/hwcontext_vulkan.h b/libavutil/hwcontext_vulkan.h
> index 406d8709c3..e89fa52927 100644
> --- a/libavutil/hwcontext_vulkan.h
> +++ b/libavutil/hwcontext_vulkan.h
> @@ -160,9 +160,7 @@ typedef enum AVVkFrameFlags {
>       * device and tiling during av_hwframe_ctx_init(). */
>      AV_VK_FRAME_FLAG_NONE              = (1ULL << 0),
>  
> -    /* Image planes will be allocated in a single VkDeviceMemory, rather
> -     * than as per-plane VkDeviceMemory allocations. Required for exporting
> -     * to VAAPI on Intel devices. */
> +    /* DEPRECATED: does nothing. */
>      AV_VK_FRAME_FLAG_CONTIGUOUS_MEMORY = (1ULL << 1),

If it's deprecated then it should actually be deprecated.

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".