From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 19BF54612C for ; Sun, 7 May 2023 18:01:30 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2676568BB37; Sun, 7 May 2023 21:01:27 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 696836802C1 for ; Sun, 7 May 2023 21:01:20 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 215B52404EC for ; Sun, 7 May 2023 20:01:20 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id 7QKefau9p9I6 for ; Sun, 7 May 2023 20:01:19 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 8428A240177 for ; Sun, 7 May 2023 20:01:19 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 6CE241601B2; Sun, 7 May 2023 20:01:19 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <20230507133255.20881-1-anton@khirnov.net> Mail-Followup-To: FFmpeg development discussions and patches Date: Sun, 07 May 2023 20:01:19 +0200 Message-ID: <168348247941.3843.15212772142026603873@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 01/13] lavu/frame: extend AVFrame.repeat_pict documentation X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Kieran Kunhya (2023-05-07 18:59:22) > On Sun, 7 May 2023, 14:34 Anton Khirnov, wrote: > > > --- > > libavutil/frame.h | 18 ++++++++++++++++-- > > 1 file changed, 16 insertions(+), 2 deletions(-) > > > > diff --git a/libavutil/frame.h b/libavutil/frame.h > > index f2b56beebb..ed3f199ce1 100644 > > --- a/libavutil/frame.h > > +++ b/libavutil/frame.h > > @@ -491,8 +491,22 @@ typedef struct AVFrame { > > void *opaque; > > > > /** > > - * When decoding, this signals how much the picture must be delayed. > > - * extra_delay = repeat_pict / (2*fps) > > + * Number of fields in this frame which should be repeated, i.e. the > > total > > + * duration of this frame should be repeat_pict + 2 normal field > > durations. > > + * > > + * For interlaced frames this field may be set to 1, which signals > > that this > > + * frame should be presented as 3 fields: beginning with the first > > field (as > > + * determined by AV_FRAME_FLAG_TOP_FIELD_FIRST being set or not), > > followed > > + * by the second field, and then the first field again. > > + * > > + * For progressive frames this field may be set to a multiple of 2, > > which > > + * signals that this frame's duration should be (repeat_pict + 2) / 2 > > + * normal frame durations. > > > This isn't correct, a progressive [coded] frame is allowed to have its > first field repeated. > > There is a difference between the coded type and the display method of a > frame. The documentation suggests otherwise. In my understanding the AVFrame interlacing flag relates to how the decoded frame is supposed to be treated (displayed or processed). It says nothing about how the frame was coded or what source it comes from. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".