From: Devin Heitmueller <devin.heitmueller@ltnglobal.com> To: ffmpeg-devel@ffmpeg.org Cc: Devin Heitmueller <dheitmueller@ltnglobal.com> Subject: [FFmpeg-devel] [PATCH v5 0/6] Add support for Closed Caption FIFO Date: Thu, 4 May 2023 18:02:14 -0400 Message-ID: <1683237740-32743-1-git-send-email-dheitmueller@ltnglobal.com> (raw) This latest update to the patch series includes several fixes from Lance Wang to the vf_ccrepack, as well as incorporating feedback from Anton Khirnov. The primary change across all the filters was to make the filter error out if the ff_ccfifo_alloc() call failed. This is reasonable because as a result of recent changes it cannot fail for any reason other than a memory allocation error. This also dovetails with the change that you're no longer allowed to call inject/extract with the AVCCFifo structure being a NULL pointer, which is what would have happened if we had allowed filters to continue even if the allocation of the ccfifo failed. We've also changed the logic such that now the caller allocates the memory for the buffer to be injected into (per Anton's suggestion), based on a new API call to get the size of the expected output buffer. This avoids dynamically allocating the buffer beforehand and then having to memcpy() the result into whatever memory it really needs to be in (e.g. AVPacket side data). Devin Heitmueller (6): ccfifo: Properly handle CEA-708 captions through framerate conversion vf_fps: properly preserve CEA-708 captions yadif: Properly preserve CEA-708 closed captions tinterlace: Properly preserve CEA-708 closed captions vf_ccrepack: Add new filter to repack CEA-708 side data decklink_enc: add support for playout of 608 captions in MOV files doc/filters.texi | 10 ++ libavdevice/Makefile | 1 + libavdevice/ccfifo.c | 24 +++++ libavdevice/decklink_common.h | 3 + libavdevice/decklink_enc.cpp | 65 +++++++++++++ libavdevice/decklink_enc_c.c | 2 +- libavfilter/Makefile | 2 + libavfilter/allfilters.c | 1 + libavfilter/ccfifo.c | 222 ++++++++++++++++++++++++++++++++++++++++++ libavfilter/ccfifo.h | 110 +++++++++++++++++++++ libavfilter/tinterlace.h | 2 + libavfilter/vf_bwdif.c | 8 ++ libavfilter/vf_ccrepack.c | 102 +++++++++++++++++++ libavfilter/vf_fps.c | 11 ++- libavfilter/vf_tinterlace.c | 11 +++ libavfilter/vf_yadif.c | 8 ++ libavfilter/vf_yadif_cuda.c | 9 ++ libavfilter/yadif.h | 2 + libavfilter/yadif_common.c | 5 + 19 files changed, 596 insertions(+), 2 deletions(-) create mode 100644 libavdevice/ccfifo.c create mode 100644 libavfilter/ccfifo.c create mode 100644 libavfilter/ccfifo.h create mode 100644 libavfilter/vf_ccrepack.c -- 1.8.3.1 _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next reply other threads:[~2023-05-04 21:06 UTC|newest] Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-05-04 22:02 Devin Heitmueller [this message] 2023-05-04 22:02 ` [FFmpeg-devel] [PATCH v5 1/6] ccfifo: Properly handle CEA-708 captions through framerate conversion Devin Heitmueller 2023-05-05 14:09 ` Lance Wang 2023-05-05 15:23 ` Devin Heitmueller 2023-05-04 22:02 ` [FFmpeg-devel] [PATCH v5 2/6] vf_fps: properly preserve CEA-708 captions Devin Heitmueller 2023-05-05 14:10 ` Michael Niedermayer 2023-05-05 14:47 ` Devin Heitmueller 2023-05-04 22:02 ` [FFmpeg-devel] [PATCH v5 3/6] yadif: Properly preserve CEA-708 closed captions Devin Heitmueller 2023-05-04 22:02 ` [FFmpeg-devel] [PATCH v5 4/6] tinterlace: " Devin Heitmueller 2023-05-04 22:02 ` [FFmpeg-devel] [PATCH v5 5/6] vf_ccrepack: Add new filter to repack CEA-708 side data Devin Heitmueller 2023-05-04 22:02 ` [FFmpeg-devel] [PATCH v5 6/6] decklink_enc: add support for playout of 608 captions in MOV files Devin Heitmueller
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=1683237740-32743-1-git-send-email-dheitmueller@ltnglobal.com \ --to=devin.heitmueller@ltnglobal.com \ --cc=dheitmueller@ltnglobal.com \ --cc=ffmpeg-devel@ffmpeg.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel This inbox may be cloned and mirrored by anyone: git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \ ffmpegdev@gitmailbox.com public-inbox-index ffmpegdev Example config snippet for mirrors. AGPL code for this site: git clone https://public-inbox.org/public-inbox.git