From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id C47BE40187 for ; Thu, 4 May 2023 18:50:47 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9B4F268C02C; Thu, 4 May 2023 21:50:27 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id E77C668BF83 for ; Thu, 4 May 2023 21:50:21 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id B54A32404EE for ; Thu, 4 May 2023 20:50:21 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id Zn_-ISZWGBuw for ; Thu, 4 May 2023 20:50:21 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 0EBA02404EC for ; Thu, 4 May 2023 20:50:21 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id EC5651601B2; Thu, 4 May 2023 20:50:20 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20230504121258.GD3718108@pb2> References: <20230502093136.B998A4107DA@natalya.videolan.org> <20230504121258.GD3718108@pb2> Mail-Followup-To: FFmpeg development discussions and patches Date: Thu, 04 May 2023 20:50:20 +0200 Message-ID: <168322622093.3843.8267699107459343430@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools/ffmpeg: always use the same path for setting InputStream.[next_]dts X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Michael Niedermayer (2023-05-04 14:12:58) > On Tue, May 02, 2023 at 09:31:35AM +0000, Anton Khirnov wrote: > > ffmpeg | branch: master | Anton Khirnov | Wed Apr 26 10:51:38 2023 +0200| [129c7bf53fbe2be4f5483ecf6fc036ff9caf05cf] | committer: Anton Khirnov > > > > fftools/ffmpeg: always use the same path for setting InputStream.[next_]dts > > > > Currently those are set in different ways depending on whether the > > stream is decoded or not, using some values from the decoder if it is. > > This is wrong, because there may be arbitrary amount of delay between > > input packets and output frames (depending e.g. on the thread count when > > frame threading is used). > > > > Always use the path that was previously used only for streamcopy. This > > should not cause any issues, because these values are now used only for > > streamcopy and discontinuity handling. > > > > This change will allow to decouple discontinuity processing from > > decoding and move it to ffmpeg_demux. It also makes the code simpler. > > > > Changes output in fate-cover-art-aiff-id3v2-remux and > > fate-cover-art-mp3-id3v2-remux, where attached pictures are now written > > in the correct order. This happens because InputStream.dts is no longer > > reset to AV_NOPTS_VALUE after decoding, so streamcopy actually sees > > valid dts values. > > > > > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=129c7bf53fbe2be4f5483ecf6fc036ff9caf05cf > > --- > > > > fftools/ffmpeg.c | 34 +++++-------------------------- > > tests/ref/fate/cover-art-aiff-id3v2-remux | 34 +++++++++++++++---------------- > > tests/ref/fate/cover-art-mp3-id3v2-remux | 22 ++++++++++---------- > > 3 files changed, 33 insertions(+), 57 deletions(-) > > Causes assertion failures > > Assertion pkt->duration >= 0 failed at fftools/ffmpeg.c:1502 > Aborted (core dumped) > > ill send you the file privately Should be fixed by the TAK patchset I just sent. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".