Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v4] avformat: add MMTP parser and MMT/TLV demuxer
Date: Mon, 01 May 2023 09:39:54 +0200
Message-ID: <168292679484.9711.5441119928663985985@lain.khirnov.net> (raw)
In-Reply-To: <CAO09jcb2e04fNJsD9B3CYDWCKe+rTVhYTzTRQ1dhaSE4OX57BQ@mail.gmail.com>

Quoting SuperFashi (2023-05-01 03:10:36)
> Thanks for the feedback. I thought across libraries meant across different
> muxers/demuxers. In which case, is there any naming scheme for functions
> that are only used within lavf? Can i just remove the avpriv_ prefix?

tl;dr: use ff_ for non-static functions used within a single library

see http://ffmpeg.org/developer.html#Naming-conventions-1 for details

> For inline, my habit is to add it when there’s only one place that uses it.
> I can remove it.

I prefer to avoid it, because it's visual clutter that in most cases has
no meaningful effect.

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2023-05-01  7:40 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-28 17:31 [FFmpeg-devel] [PATCH] " SuperFashi
2023-04-28 20:44 ` Michael Niedermayer
2023-04-29  5:44 ` [FFmpeg-devel] [PATCH v2] " SuperFashi
2023-04-29  5:49   ` [FFmpeg-devel] [PATCH v3] " SuperFashi
2023-04-29  5:53     ` [FFmpeg-devel] [PATCH v4] " SuperFashi
2023-04-29 18:05       ` Michael Niedermayer
2023-04-30  3:32         ` SuperFashi
2023-04-30 15:14           ` Anton Khirnov
2023-05-01  1:10             ` SuperFashi
2023-05-01  7:39               ` Anton Khirnov [this message]
2023-05-01 11:01       ` [FFmpeg-devel] [PATCH v5] " SuperFashi
2023-05-02 12:57         ` Paul B Mahol
2023-05-02 13:43           ` SuperFashi
2023-05-03 13:02         ` [FFmpeg-devel] [PATCH v6] " SuperFashi
2023-05-17  8:27           ` SuperFashi
2023-04-29 11:38   ` [FFmpeg-devel] [PATCH v2] " Jean-Baptiste Kempf
2023-04-29 12:03     ` SuperFashi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=168292679484.9711.5441119928663985985@lain.khirnov.net \
    --to=anton@khirnov.net \
    --cc=ffmpeg-devel@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git