From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 226AC40D13 for ; Sun, 30 Apr 2023 15:14:38 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 61E0D68C06B; Sun, 30 Apr 2023 18:14:35 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 45ACE68BE2B for ; Sun, 30 Apr 2023 18:14:29 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 11F522404EC for ; Sun, 30 Apr 2023 17:14:29 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id 9e0DQ_LH279u for ; Sun, 30 Apr 2023 17:14:28 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 83445240177 for ; Sun, 30 Apr 2023 17:14:28 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 492DD1601B2; Sun, 30 Apr 2023 17:14:27 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <20230429054950.6148-1-admin@superfashi.com> <20230429055306.7470-1-admin@superfashi.com> <20230429180549.GJ275832@pb2> Mail-Followup-To: FFmpeg development discussions and patches Date: Sun, 30 Apr 2023 17:14:27 +0200 Message-ID: <168286766725.3843.17415586749468282055@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH v4] avformat: add MMTP parser and MMT/TLV demuxer X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting SuperFashi (2023-04-30 05:32:46) > Thanks. Is there anything else that does not fit codebase tradition? Please > point everything out so I could send a new patch. Some quick notes: * why are there avpriv_ functions when everything you do is libavformat? avpriv is for sharing functions across libraries * header order (first system, then ours, sort each of those alphabetically) * opening brace for function declarations should be on its own line * very long lines everywhere; we have a soft limit of 80 characters (can be exceeded where really needed, but should be done sparingly) if your code needs more then it's a sign that you have too much indentation or your names are too long * inline specifiers all over the place, I think modern compilers largely ignore them; even if they didn't it's better to leave such decisions to compilers in most cases -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".