From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v4] avformat: add MMTP parser and MMT/TLV demuxer
Date: Sun, 30 Apr 2023 17:14:27 +0200
Message-ID: <168286766725.3843.17415586749468282055@lain.khirnov.net> (raw)
In-Reply-To: <CAO09jcYGNVPj_vz8Z49qHbOTz578GH9oZB3QqMdQuzSkJO_iEA@mail.gmail.com>
Quoting SuperFashi (2023-04-30 05:32:46)
> Thanks. Is there anything else that does not fit codebase tradition? Please
> point everything out so I could send a new patch.
Some quick notes:
* why are there avpriv_ functions when everything you do is libavformat?
avpriv is for sharing functions across libraries
* header order (first system, then ours, sort each of those
alphabetically)
* opening brace for function declarations should be on its own line
* very long lines everywhere; we have a soft limit of 80 characters (can
be exceeded where really needed, but should be done sparingly)
if your code needs more then it's a sign that you have too much
indentation or your names are too long
* inline specifiers all over the place, I think modern compilers largely
ignore them; even if they didn't it's better to leave such decisions
to compilers in most cases
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-04-30 15:14 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-28 17:31 [FFmpeg-devel] [PATCH] " SuperFashi
2023-04-28 20:44 ` Michael Niedermayer
2023-04-29 5:44 ` [FFmpeg-devel] [PATCH v2] " SuperFashi
2023-04-29 5:49 ` [FFmpeg-devel] [PATCH v3] " SuperFashi
2023-04-29 5:53 ` [FFmpeg-devel] [PATCH v4] " SuperFashi
2023-04-29 18:05 ` Michael Niedermayer
2023-04-30 3:32 ` SuperFashi
2023-04-30 15:14 ` Anton Khirnov [this message]
2023-05-01 1:10 ` SuperFashi
2023-05-01 7:39 ` Anton Khirnov
2023-05-01 11:01 ` [FFmpeg-devel] [PATCH v5] " SuperFashi
2023-05-02 12:57 ` Paul B Mahol
2023-05-02 13:43 ` SuperFashi
2023-05-03 13:02 ` [FFmpeg-devel] [PATCH v6] " SuperFashi
2023-05-17 8:27 ` SuperFashi
2023-04-29 11:38 ` [FFmpeg-devel] [PATCH v2] " Jean-Baptiste Kempf
2023-04-29 12:03 ` SuperFashi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168286766725.3843.17415586749468282055@lain.khirnov.net \
--to=anton@khirnov.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git