From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 797A046001 for ; Sat, 29 Apr 2023 09:42:03 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 3590668C066; Sat, 29 Apr 2023 12:41:59 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 8B3FB68C046 for ; Sat, 29 Apr 2023 12:41:52 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 3ED612404EC for ; Sat, 29 Apr 2023 11:41:52 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id y4H_nvOOKinH for ; Sat, 29 Apr 2023 11:41:51 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 67583240177 for ; Sat, 29 Apr 2023 11:41:51 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 490DB1601B2; Sat, 29 Apr 2023 11:41:51 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <20230428095508.221826-1-george@nsup.org> <20230428095508.221826-5-george@nsup.org> Mail-Followup-To: FFmpeg development discussions and patches Date: Sat, 29 Apr 2023 11:41:51 +0200 Message-ID: <168276131126.3843.11789945625076765172@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 5/8] lavu: add a JSON writer API (WIP) X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Nicolas George (2023-04-29 11:11:59) > Nicolas George (12023-04-28): > > Signed-off-by: Nicolas George > > --- > > libavutil/Makefile | 1 + > > libavutil/json.c | 368 +++++++++++++++++++++++++++++++++++ > > libavutil/json.h | 470 +++++++++++++++++++++++++++++++++++++++++++++ > > 3 files changed, 839 insertions(+) > > create mode 100644 libavutil/json.c > > create mode 100644 libavutil/json.h > > I forgot to write: I wrote this code not only because we have half-baked > JSON output in multiple places in the code As far as I can see, there are exactly two places in the codebase that produce JSON: af_loudnorm and ffprobe. af_loudnorm: * can optionally produce final filter stats as JSON output with av_log() * the relevant code has ~25 lines and is unlikely to be simplified by this * IMO the filter should not be doing this at all and instead produce some sort of a struct and let the users process it as they wish ffprobe: * is not one of the libraries, but rather their caller * we are not in business of providing random non-multimedia-related services to callers, unless they are useful in our libraries; if this code is only useful in ffprobe then it should live in fftools/ * it is not at all obvious that switching ffprobe to this code would be an improvement; a patch actually demonstrating this would be most useful -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".