From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 91A0B458DA for ; Thu, 27 Apr 2023 07:52:09 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B89FF68BF1F; Thu, 27 Apr 2023 10:52:05 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 17178680105 for ; Thu, 27 Apr 2023 10:51:59 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id CD22F2404EE; Thu, 27 Apr 2023 09:51:58 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id KU-YY6FVeqJY; Thu, 27 Apr 2023 09:51:58 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 504262404EC; Thu, 27 Apr 2023 09:51:58 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 345401601B2; Thu, 27 Apr 2023 09:51:58 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20230426175302.946-1-pal@sandflow.com> References: <20230426175302.946-1-pal@sandflow.com> Mail-Followup-To: FFmpeg development discussions and patches , Pierre-Anthony Lemieux Date: Thu, 27 Apr 2023 09:51:58 +0200 Message-ID: <168258191818.3843.4665255914688205385@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 1/2] avformat/imf: fix invalid resource handling X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Pierre-Anthony Lemieux Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting pal@sandflow.com (2023-04-26 19:53:01) > From: Pierre-Anthony Lemieux > > --- > libavformat/imf_cpl.c | 14 ++++++-------- > 1 file changed, 6 insertions(+), 8 deletions(-) > > diff --git a/libavformat/imf_cpl.c b/libavformat/imf_cpl.c > index ad84a68b13..a7cf5fa360 100644 > --- a/libavformat/imf_cpl.c > +++ b/libavformat/imf_cpl.c > @@ -608,11 +608,10 @@ static int push_main_audio_sequence(xmlNodePtr audio_sequence_elem, FFIMFCPL *cp > ret = fill_trackfile_resource(resource_elem, > &vt->resources[vt->resource_count], > cpl); > - vt->resource_count++; > - if (ret) { > + if (ret) > av_log(NULL, AV_LOG_ERROR, "Invalid Resource\n"); > - continue; Should an error here not propagate to the caller? Unrelated, but all this logging to NULL is very evil. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".