From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Pierre-Anthony Lemieux <pal@palemieux.com>
Subject: Re: [FFmpeg-devel] [PATCH 1/2] avformat/imf: fix invalid resource handling
Date: Thu, 27 Apr 2023 09:51:58 +0200
Message-ID: <168258191818.3843.4665255914688205385@lain.khirnov.net> (raw)
In-Reply-To: <20230426175302.946-1-pal@sandflow.com>
Quoting pal@sandflow.com (2023-04-26 19:53:01)
> From: Pierre-Anthony Lemieux <pal@palemieux.com>
>
> ---
> libavformat/imf_cpl.c | 14 ++++++--------
> 1 file changed, 6 insertions(+), 8 deletions(-)
>
> diff --git a/libavformat/imf_cpl.c b/libavformat/imf_cpl.c
> index ad84a68b13..a7cf5fa360 100644
> --- a/libavformat/imf_cpl.c
> +++ b/libavformat/imf_cpl.c
> @@ -608,11 +608,10 @@ static int push_main_audio_sequence(xmlNodePtr audio_sequence_elem, FFIMFCPL *cp
> ret = fill_trackfile_resource(resource_elem,
> &vt->resources[vt->resource_count],
> cpl);
> - vt->resource_count++;
> - if (ret) {
> + if (ret)
> av_log(NULL, AV_LOG_ERROR, "Invalid Resource\n");
> - continue;
Should an error here not propagate to the caller?
Unrelated, but all this logging to NULL is very evil.
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-04-27 7:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-26 17:53 pal
2023-04-26 17:53 ` [FFmpeg-devel] [PATCH 2/2] avformat/tests/imf: add invalid resource test pal
2023-04-27 7:51 ` Anton Khirnov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168258191818.3843.4665255914688205385@lain.khirnov.net \
--to=anton@khirnov.net \
--cc=ffmpeg-devel@ffmpeg.org \
--cc=pal@palemieux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git