From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 6237F458D4 for ; Thu, 27 Apr 2023 07:48:40 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5B71268BF10; Thu, 27 Apr 2023 10:48:38 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 2AB3668B778 for ; Thu, 27 Apr 2023 10:48:32 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id C40B92404EE for ; Thu, 27 Apr 2023 09:48:31 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id Lqo_Gzd1eeY1 for ; Thu, 27 Apr 2023 09:48:31 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 2B5762404EC for ; Thu, 27 Apr 2023 09:48:31 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 0E8351601B2; Thu, 27 Apr 2023 09:48:31 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20230426115410.GD275832@pb2> References: <20230424155553.24560-1-anton@khirnov.net> <20230426115410.GD275832@pb2> Mail-Followup-To: FFmpeg development discussions and patches Date: Thu, 27 Apr 2023 09:48:31 +0200 Message-ID: <168258171102.3843.14052884096678891651@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 1/3] lavf/dv: do not set video timebase more than once X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Michael Niedermayer (2023-04-26 13:54:10) > On Mon, Apr 24, 2023 at 05:55:51PM +0200, Anton Khirnov wrote: > > Current code will call avpriv_set_pts_info() for each video frame, > > possibly setting a different timebase if the stream framerate changes. > > This violates API conventions, as the timebase is supposed to stay > > constant after stream creation. > > > > Change the demuxer to set a single timebase that is fine enough to > > handle all supported DV framerates. > > > > The seek tests change slightly because the new timebase is more > > granular. > > --- > > libavcodec/dv.h | 3 +++ > > libavformat/dv.c | 25 ++++++++++++++++++++----- > > tests/ref/seek/lavf-dv | 16 ++++++++-------- > > tests/ref/seek/vsynth_lena-dv | 24 ++++++++++++------------ > > tests/ref/seek/vsynth_lena-dv-411 | 24 ++++++++++++------------ > > tests/ref/seek/vsynth_lena-dv-50 | 24 ++++++++++++------------ > > 6 files changed, 67 insertions(+), 49 deletions(-) > > This breaks: > > ./ffmpeg -ss 4:56 -i ~/tickets/4086/Oca-Agu\ 1995.avi -codec copy -t 1 -bitexact 4086-30frames.dv > (the file is empty after the patch) > > The file seems no longer available on the original link and a little big > ill put it in your home directory on the server probably in 30+min or so. > once you are done with it please delete it off the server so it doesnt eat > diskspace Thank you, file downloaded and deleted. Seems we do not have any FATE tests for dv in avi - do you (or anyone else) have a reasonably small sample that can be used for that? -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".