Re: [FFmpeg-devel] [PATCH 23/25] fftools/ffmpeg_filter: add filtergraph private data

From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 23/25] fftools/ffmpeg_filter: add filtergraph private data
Date: Mon, 24 Apr 2023 21:17:37 +0200
Message-ID: <168236385755.3843.9294759004440412931@lain.khirnov.net> (raw)
In-Reply-To: <ZEbLFfCf4k84DH/E@phare.normalesup.org>

Quoting Nicolas George (2023-04-24 20:31:49)
> Anton Khirnov (12023-04-24):
> > So when I wanted to make changes to libavfilter recently, you claimed
> > your familiarity with the code makes you more qualified to judge
> > readability. Now my familiarity with the code makes me LESS qualified.
> > Curious.
> 
> There is a difference between long-term knowledge of a large part of the
> code and a short-term acquaintance with a limited slice of the code, I
> hope you realize.

I have no idea what you mean by this.

> > We've also been moving private state to private data for many years now
> > and none of your conjectured concerns materialized, to the contrary code
> > became easier to maintain.
> 
> Untrue. For example, every instance of FFFormatContext in the code gives
> places where the code has become that much more annoying to maintain.
> Maybe the same code has become more maintainable at the same time due to
> other changes, but the fact remains that these changes make it harder to
> work on the code.

> true
> fact

You keep using these words. I don't think they mean what you think they
mean. The only fact here is that the quoted paragraph is YOUR PERSONAL
OPINION, which ZERO other developers expressed support for.

On the other hand, the approach under discussion has explicit support
from multiple highly active developers.

> > Now that would be pure noise.
> 
> The only noise here is all the fgp_from_fg() you want to liter over the
> code and the extra variables it requires.
> 
> > I have no idea what are you even objecting to. What is even
> > controversial about not exposing state that does not need to be exposed?
> 
> I have explained time and again: I oppose to any change that requires us
> to remember or check which structure a given field belongs to when it is
> not already obvious by its semantic.

You are too late, many such changes have already been pushed in the last
several years. Nobody except you opposes them and the likelihood of
reversing them is extremely low. This whole thread is a pointless waste
of time that could be spend doing something actually useful.

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".