From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7377845B97 for ; Mon, 24 Apr 2023 12:07:32 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AB2DB68BF81; Mon, 24 Apr 2023 15:07:29 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 49B8B68BF70 for ; Mon, 24 Apr 2023 15:07:23 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id E82C52404EE for ; Mon, 24 Apr 2023 14:07:22 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id HtTo90hKe7Ub for ; Mon, 24 Apr 2023 14:07:22 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 5CEEF2404EC for ; Mon, 24 Apr 2023 14:07:22 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 3F5941601B2; Mon, 24 Apr 2023 14:07:22 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <20230419195243.2974-1-anton@khirnov.net> <20230419195243.2974-23-anton@khirnov.net> <168233503763.3843.15441944598302423310@lain.khirnov.net> <168233747463.3843.6914979374280115185@lain.khirnov.net> Mail-Followup-To: FFmpeg development discussions and patches Date: Mon, 24 Apr 2023 14:07:22 +0200 Message-ID: <168233804222.3843.2176038618353077915@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 23/25] fftools/ffmpeg_filter: add filtergraph private data X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Nicolas George (2023-04-24 13:59:43) > Anton Khirnov (12023-04-24): > > We'll have to disagree about this then. I belive lack of proper > > structure is currently the biggest problem in ffmpeg CLI. > > I do not disagree on this. But this patch does not help, it just makes > the code locally less readable. If it is to be useful at all, it is at > least severely premature. What exactly is less readable? One variable gets its scope reduced, that is a win in my book. And obviously I'm not stopping there, other things will be moved to this private struct in future patches, I just prefer to avoid giant patchsets when possible. Also note that exactly the same pattern is used in ffmpeg_demux, ffmpeg_mux, and ffmpeg_enc (and soon in ffmpeg_dec). -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".