From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH v2] fftools/ffmpeg_mux: fix reporting muxer EOF as error
Date: Mon, 24 Apr 2023 12:08:15 +0200
Message-ID: <168233089586.3843.17645935752826345939@lain.khirnov.net> (raw)
In-Reply-To: <299fbcbb-5730-f06-8532-ee0e33a1a39@passwd.hu>
Quoting Marton Balint (2023-04-24 11:09:44)
>
>
> On Sun, 23 Apr 2023, Anton Khirnov wrote:
>
> > Quoting Marton Balint (2023-04-23 20:15:13)
> >>
> >>
> >> On Sun, 23 Apr 2023, Anton Khirnov wrote:
> >> I don't understand. A good program propagates back error conditions to the
> >> user, and not hides them silently.
> >
> > I do not think blanket claims such as this are a good idea. What is or
> > is not considered "an error condition" depends on the context.
> >
> > As I said before - I don't see why a muxer should ever return
> > AVERROR_EOF to signal a legitimate muxing error.
>
> The real risk is that they unintentionally do that, when the error code is
> coming from some underlying operation for example.
>
> So previsouly a muxer could return any error code to signal error
> condition and reasonably assume that ffmpeg.c will report it back to the
> user as an error.
Also, muxers absolutely must not make any assumptions about ffmpeg CLI
behavior, because other callers exist and they must all be treated
equally.
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-04-24 10:08 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-22 12:56 Zhao Zhili
2023-04-22 15:44 ` Anton Khirnov
2023-04-23 9:12 ` Marton Balint
2023-04-23 9:34 ` Anton Khirnov
2023-04-23 9:42 ` Marton Balint
2023-04-23 9:48 ` "zhilizhao(赵志立)"
2023-04-23 9:51 ` Anton Khirnov
2023-04-23 10:05 ` Marton Balint
2023-04-23 10:07 ` Nicolas George
2023-04-23 12:01 ` Anton Khirnov
2023-04-23 18:15 ` Marton Balint
2023-04-23 20:16 ` Anton Khirnov
2023-04-24 9:09 ` Marton Balint
2023-04-24 9:19 ` Nicolas George
2023-04-24 10:02 ` Anton Khirnov
2023-04-24 18:41 ` Marton Balint
2023-04-24 19:24 ` Anton Khirnov
2023-04-24 19:42 ` Marton Balint
2023-04-24 21:08 ` Anton Khirnov
2023-04-25 14:37 ` Nicolas George
2023-04-24 20:41 ` Nicolas George
2023-04-24 10:08 ` Anton Khirnov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=168233089586.3843.17645935752826345939@lain.khirnov.net \
--to=anton@khirnov.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git