From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 31AEB45804 for ; Mon, 24 Apr 2023 07:47:24 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id B274068BF49; Mon, 24 Apr 2023 10:47:21 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4A13468BE6F for ; Mon, 24 Apr 2023 10:47:15 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id EF6232404EE for ; Mon, 24 Apr 2023 09:47:14 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id E0ijUlhGlqCI for ; Mon, 24 Apr 2023 09:47:14 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 45DFD2404EC for ; Mon, 24 Apr 2023 09:47:14 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 1FE151601B2; Mon, 24 Apr 2023 09:47:14 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <168231816356.3843.9636378638988629877@lain.khirnov.net> Mail-Followup-To: FFmpeg development discussions and patches Date: Mon, 24 Apr 2023 09:47:14 +0200 Message-ID: <168232243409.3843.1464660790318647692@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] avdevice/pipewire_dec: pipewire video capture X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting metamuffin (2023-04-24 09:21:06) > On 23-04-24 08:36, Anton Khirnov wrote: > > Thanks for your reply! > > > Also, your email client mangled your patch. > > Sorry for that, I will resend the updated patch soon. (hopefully using > git send-mail) > > > This seems like it should be a lavfi source instead. > > If you mean libavfilter, then I am confused. I thought about either > submitting to libavformat or libavdevice. I chose the latter because > pulse is already in there and is very similar to pipewire in that sense. Many things are in libavdevice mainly for historical and inertia reasons: libavfilter did not exist (or was not mature enough) when they were added. I'd say lavfi is more appropriate for raw sources like this, since you don't have to resort to ugly hacks or expensive copies to wrap frames into packets. You can also do things like export hardware surfaces directly. > Also, now that I have a message to note this, I am planning to also > implement pipewire video output, audio input and output as well in the > near future. Should I first accumulate all commits or submit the working > parts gradually? I am also not sure, whether or not pipewire support is > even wanted in ffmpeg. Separate commits are better - they are easier to review and it's less likely that disagreement on one component blocks everything. I don't know if pipewire output is used purely for playback or more general processing - in the former case I'm not convinced these outputs would be very useful, because our APIs do not give the user enough control over timing to allow serious use. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".