From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E067145EED for ; Mon, 17 Apr 2023 17:07:29 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9A1ED68BE4F; Mon, 17 Apr 2023 20:07:26 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 40086689C13 for ; Mon, 17 Apr 2023 20:07:20 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id E33A52404EE for ; Mon, 17 Apr 2023 19:07:19 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id XHqatfn2bm7h for ; Mon, 17 Apr 2023 19:07:19 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 5C45A2404EC for ; Mon, 17 Apr 2023 19:07:19 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 3DB081601B2; Mon, 17 Apr 2023 19:07:19 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20230417153408.1225-1-jamrial@gmail.com> References: <20230417153408.1225-1-jamrial@gmail.com> Mail-Followup-To: FFmpeg development discussions and patches Date: Mon, 17 Apr 2023 19:07:19 +0200 Message-ID: <168175123922.3843.1216036854720395570@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] avutil/frame: change the type of the crop fields to unsigned in the next major bump X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting James Almer (2023-04-17 17:34:08) > size_t is unnecessarily big on 64bit arches when width and height are ints. > > Signed-off-by: James Almer > --- > libavutil/frame.h | 7 +++++++ > libavutil/version.h | 1 + > 2 files changed, 8 insertions(+) > > diff --git a/libavutil/frame.h b/libavutil/frame.h > index f85d630c5c..e10a1c65e3 100644 > --- a/libavutil/frame.h > +++ b/libavutil/frame.h > @@ -722,10 +722,17 @@ typedef struct AVFrame { > * the frame intended for presentation. > * @{ > */ > +#if FF_API_CROP_SIZE_T > size_t crop_top; > size_t crop_bottom; > size_t crop_left; > size_t crop_right; > +#else > + unsigned int crop_top; > + unsigned int crop_bottom; > + unsigned int crop_left; > + unsigned int crop_right; > +#endif Ok, but should be mentioned in APIchanges -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".