Re: [FFmpeg-devel] [PATCH] avutil/frame: change the type of the crop fields to unsigned in the next major bump

From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avutil/frame: change the type of the crop fields to unsigned in the next major bump
Date: Mon, 17 Apr 2023 19:07:19 +0200
Message-ID: <168175123922.3843.1216036854720395570@lain.khirnov.net> (raw)
In-Reply-To: <20230417153408.1225-1-jamrial@gmail.com>

Quoting James Almer (2023-04-17 17:34:08)
> size_t is unnecessarily big on 64bit arches when width and height are ints.
> 
> Signed-off-by: James Almer <jamrial@gmail.com>
> ---
>  libavutil/frame.h   | 7 +++++++
>  libavutil/version.h | 1 +
>  2 files changed, 8 insertions(+)
> 
> diff --git a/libavutil/frame.h b/libavutil/frame.h
> index f85d630c5c..e10a1c65e3 100644
> --- a/libavutil/frame.h
> +++ b/libavutil/frame.h
> @@ -722,10 +722,17 @@ typedef struct AVFrame {
>       * the frame intended for presentation.
>       * @{
>       */
> +#if FF_API_CROP_SIZE_T
>      size_t crop_top;
>      size_t crop_bottom;
>      size_t crop_left;
>      size_t crop_right;
> +#else
> +    unsigned int crop_top;
> +    unsigned int crop_bottom;
> +    unsigned int crop_left;
> +    unsigned int crop_right;
> +#endif

Ok, but should be mentioned in APIchanges

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".