From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 425F644FEA for ; Sun, 16 Apr 2023 19:21:48 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id D689E68B63F; Sun, 16 Apr 2023 22:21:44 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id C993768997B for ; Sun, 16 Apr 2023 22:21:38 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 389C02404EE for ; Sun, 16 Apr 2023 21:21:37 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id y4CI6dknYe4R for ; Sun, 16 Apr 2023 21:21:36 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 778692404EC for ; Sun, 16 Apr 2023 21:21:36 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 78E551601B2; Sun, 16 Apr 2023 21:21:35 +0200 (CEST) From: Anton Khirnov To: Ffmpeg Devel In-Reply-To: References: Mail-Followup-To: Ffmpeg Devel Date: Sun, 16 Apr 2023 21:21:35 +0200 Message-ID: <168167289545.3843.15064702352157500856@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 31/92] Vulkan patchset part 1 - common code changes X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Lynne (2023-03-14 07:33:43) > From 56ebb0bc2fd4b856196e6436b4c18af8e4d1a86a Mon Sep 17 00:00:00 2001 > From: Lynne > Date: Thu, 10 Mar 2022 18:08:53 +0100 > Subject: [PATCH 05/92] h264_parser: expose idr_pic_id > > Vulkan needs it. > --- > libavcodec/h264_parse.h | 1 + > libavcodec/h264_parser.c | 2 +- > 2 files changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/h264_parse.h b/libavcodec/h264_parse.h > index 4ee863df66..4ba0add4f2 100644 > --- a/libavcodec/h264_parse.h > +++ b/libavcodec/h264_parse.h > @@ -85,6 +85,7 @@ typedef struct H264POCContext { > int delta_poc_bottom; > int delta_poc[2]; > int frame_num; > + int idr_pic_id; > int prev_poc_msb; ///< poc_msb of the last reference pic for POC type 0 > int prev_poc_lsb; ///< poc_lsb of the last reference pic for POC type 0 > int frame_num_offset; ///< for POC type 2 > diff --git a/libavcodec/h264_parser.c b/libavcodec/h264_parser.c > index 46134a1c48..1c330484c1 100644 > --- a/libavcodec/h264_parser.c > +++ b/libavcodec/h264_parser.c > @@ -432,7 +432,7 @@ static inline int parse_nal_units(AVCodecParserContext *s, > } > > if (nal.type == H264_NAL_IDR_SLICE) > - get_ue_golomb_long(&nal.gb); /* idr_pic_id */ > + p->poc.idr_pic_id = get_ue_golomb_long(&nal.gb); /* idr_pic_id */ > if (sps->poc_type == 0) { > p->poc.poc_lsb = get_bits(&nal.gb, sps->log2_max_poc_lsb); This change cannot possibly have any effect on any Vulkan code. I told you this in the first review round, then we discussed it on IRC with a detailed explanation why. And look, the same patch is here again with no changes and no explanation. I sure hope my other comments weren't treated the same way. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".