From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 8D5FA45EB2 for ; Fri, 14 Apr 2023 16:51:22 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 09DD168BEEA; Fri, 14 Apr 2023 19:51:20 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id BD98468BE10 for ; Fri, 14 Apr 2023 19:51:13 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 7E5CC2404EE for ; Fri, 14 Apr 2023 18:51:13 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id 0oJzzDMuVyQK for ; Fri, 14 Apr 2023 18:51:12 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id E4D6E2404EC for ; Fri, 14 Apr 2023 18:51:12 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id D00671601B2; Fri, 14 Apr 2023 18:51:11 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20230414164244.15264-7-anton@khirnov.net> References: <20230414164244.15264-1-anton@khirnov.net> <20230414164244.15264-7-anton@khirnov.net> Mail-Followup-To: FFmpeg development discussions and patches Date: Fri, 14 Apr 2023 18:51:11 +0200 Message-ID: <168149107180.3843.8179775107588901217@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 7/7] fftools/ffmpeg: propagate frame durations to packets when encoding X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Anton Khirnov (2023-04-14 18:42:44) > Remove now-obsolete code setting packet durations pre-muxing for CFR > encoded video. > > Changes output in the following FATE tests: > * numerous adpcm tests > * ffmpeg-filter_complex_audio > * lavf-asf > * lavf-mkv > * lavf-mkv_attachment > * matroska-encoding-delay > All of these change due to the fact that the output duration is now > the actual input data duration and does not include padding added by > the encoder. It is not entirely clear to me that recording "user audio duration" (i.e. samples submitted by the user to the encoder) rather than "coded audio duration" (i.e. user duration plus any padding added by the encoder) in containers (e.g. the 'fact' chunk in WAV, or duration metadata in matroska) is the correct thing to do. It seems more elegant, but may cause issues I'm not aware of. Opinions and arguments welcome. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".