From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id A850E44F61 for ; Wed, 12 Apr 2023 11:56:03 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 2AA6B68BBFD; Wed, 12 Apr 2023 14:56:00 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 77F6F68ADCB for ; Wed, 12 Apr 2023 14:55:53 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 3606F2404EE for ; Wed, 12 Apr 2023 13:55:53 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id xdtvCDSInjz1 for ; Wed, 12 Apr 2023 13:55:52 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 97C152404EC for ; Wed, 12 Apr 2023 13:55:52 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 820F11601B2; Wed, 12 Apr 2023 13:55:52 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: References: <20230411203851.65044-1-jamrial@gmail.com> <20230411203851.65044-2-jamrial@gmail.com> <168128699197.27013.12977793193161732244@lain.khirnov.net> Mail-Followup-To: FFmpeg development discussions and patches Date: Wed, 12 Apr 2023 13:55:52 +0200 Message-ID: <168130055249.27013.1669357758963017625@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 2/3] avcodec: use the new event flags field instead of setting AVFrame.palette_has_changed X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting James Almer (2023-04-12 13:26:48) > On 4/12/2023 5:09 AM, Anton Khirnov wrote: > > Quoting James Almer (2023-04-11 22:38:50) > >> diff --git a/doc/APIchanges b/doc/APIchanges > >> index 59216231f9..85060768b3 100644 > >> --- a/doc/APIchanges > >> +++ b/doc/APIchanges > >> @@ -4,6 +4,7 @@ API changes, most recent first: > >> > >> 2023-04-11 - xxxxxxxxxx - lavc 60.10.100 - avcodec.h > >> Add event_flags to AVCodecContext. > >> + Add AVCTX_EVENT_FLAG_PALETTE_HAS_CHANGED. > > > > I think we should first figure out how is the field supposed to be > > useful to our users. Maybe it's not and we can just remove it. > > That's fine. I have no idea if it's actually used or useful (You can > always just memcmp(prev->data[1], cur->data[1], 256) on every frame > after all), but removing without replacement tends to be controversial, > hence why i did this. E.g. if the field is supposed to be useful in filters, then your change would break that use case. More generally I don't think we should be adding new APIs with no understanding of how they are supposed to be used. Deprecating that field entirely and waiting for someone to object seems better to me. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".