From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4DDD844F4E for ; Wed, 12 Apr 2023 05:59:51 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id EE31D68BD76; Wed, 12 Apr 2023 08:59:47 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CAD80689F35 for ; Wed, 12 Apr 2023 08:59:41 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 41CF02404EE for ; Wed, 12 Apr 2023 07:59:41 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id qottdx7mgHBx for ; Wed, 12 Apr 2023 07:59:40 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 7C4F52404EC for ; Wed, 12 Apr 2023 07:59:40 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 5C33D1601B2; Wed, 12 Apr 2023 07:59:40 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <3170a159-16ac-9f0a-8fca-cf2ce26e0ace@gmail.com> References: <20230409140853.28858-1-anton@khirnov.net> <20230409140853.28858-25-anton@khirnov.net> <3170a159-16ac-9f0a-8fca-cf2ce26e0ace@gmail.com> Mail-Followup-To: FFmpeg development discussions and patches Date: Wed, 12 Apr 2023 07:59:40 +0200 Message-ID: <168127918034.27013.14647820710324112296@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 25/29] fftools/ffmpeg_demux: set the timebase on demuxed packets X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting James Almer (2023-04-12 04:49:00) > On 4/9/2023 11:08 AM, Anton Khirnov wrote: > > Simplifies tracking what timebase are the timestamps in. Will be useful > > in following commits. > > --- > > fftools/ffmpeg_demux.c | 16 +++++++++------- > > 1 file changed, 9 insertions(+), 7 deletions(-) > > > > diff --git a/fftools/ffmpeg_demux.c b/fftools/ffmpeg_demux.c > > index f2da0826ad..7ff57273c9 100644 > > --- a/fftools/ffmpeg_demux.c > > +++ b/fftools/ffmpeg_demux.c > > @@ -194,15 +194,17 @@ static void ts_fixup(Demuxer *d, AVPacket *pkt, int *repeat_pict) > > const int64_t start_time = ifile->start_time_effective; > > int64_t duration; > > > > + pkt->time_base = ist->st->time_base; > > Might be a good future-proof idea to check first if pkt->time_base is > already set or not. The doxy says demuxers themselves may start doing so > at some point. Why would that make any difference? The timestamps have to be in the stream timebase, anything else would be an API break. So whatever value is or is not written there by the demuxer, we can always overwrite it by what we know has to be the corect timebase. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".