Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Zhao Zhili <zhilizhao@tencent.com>
Subject: Re: [FFmpeg-devel] [PATCH] avutil/internal: remove timer.h again
Date: Tue, 11 Apr 2023 13:34:11 +0200
Message-ID: <168121285141.27013.16730915788127628603@lain.khirnov.net> (raw)
In-Reply-To: <tencent_38702C2D019AC840689A3D9F00AB334E7F08@qq.com>

Quoting Zhao Zhili (2023-04-05 16:50:08)
> From: Zhao Zhili <zhilizhao@tencent.com>
> 
> timer.h has been removed from internal.h, and then added back with
> 3e6088f for convenience. This patch removed it again for the
> following reasons:
> 
> 1. Only includes what's necessary is a common and safe strategy.
> 
> 2. It fixed some build errors on Android:
>   a. libavutil/timer.h includes sys/ioctl.h, and ioctl.h includes
>      termios.h on Android.
>   b. termios.h reserves names prefixed with ‘c_’, ‘V’, ‘I’, ‘O’, and
>      ‘TC’; and names prefixed with ‘B’ followed by a digit.
>   c. libavcodec uses B0 B1 and so on as variable names a lot. So
>      the code failed to build with --enable-linux-perf, or
>      --target-os=Linux.
> ---
>  libavutil/internal.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/libavutil/internal.h b/libavutil/internal.h
> index 454c59aa50..001103142b 100644
> --- a/libavutil/internal.h
> +++ b/libavutil/internal.h
> @@ -40,7 +40,6 @@
>  #include <stdio.h>
>  #include "config.h"
>  #include "attributes.h"
> -#include "timer.h"
>  #include "macros.h"
>  #include "pixfmt.h"

I am in favor of this.

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".

  reply	other threads:[~2023-04-11 11:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-05 14:50 Zhao Zhili
2023-04-11 11:34 ` Anton Khirnov [this message]
2023-04-13 12:09   ` "zhilizhao(赵志立)"
2023-04-14 12:25     ` "zhilizhao(赵志立)"

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=168121285141.27013.16730915788127628603@lain.khirnov.net \
    --to=anton@khirnov.net \
    --cc=ffmpeg-devel@ffmpeg.org \
    --cc=zhilizhao@tencent.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git