From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 542BD45A0F for ; Sun, 9 Apr 2023 14:06:53 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 7151768AB9E; Sun, 9 Apr 2023 17:06:50 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id A614E689CE2 for ; Sun, 9 Apr 2023 17:06:43 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 48BB22404EE for ; Sun, 9 Apr 2023 16:06:43 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id J4gU3CQ6p-2d for ; Sun, 9 Apr 2023 16:06:42 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 41BF32404EC for ; Sun, 9 Apr 2023 16:06:42 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 95AA11601B2; Sun, 9 Apr 2023 16:06:40 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <9258ec2c-6635-1edc-f695-1cc2629c6ac8@passwd.hu> References: <20230408183724.12479-1-cus@passwd.hu> <20230408211411.GC4538@pb2> <9258ec2c-6635-1edc-f695-1cc2629c6ac8@passwd.hu> Mail-Followup-To: FFmpeg development discussions and patches Date: Sun, 09 Apr 2023 16:06:40 +0200 Message-ID: <168104920057.27013.13730427288046563715@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] avformat/mov: remove hack breaking creation time parsing X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Marton Balint (2023-04-09 15:49:33) > > > On Sat, 8 Apr 2023, Michael Niedermayer wrote: > > > On Sat, Apr 08, 2023 at 08:37:24PM +0200, Marton Balint wrote: > >> Commit 23eeffcd48a15e73fb2649b712870b6d101c5471 added a hack to support invalid > >> files where the creation date was encoded as a classic unix timestamp. This > >> broke however valid files having creation dates before the unix epoch. > >> > >> Signed-off-by: Marton Balint > >> --- > >> libavformat/mov.c | 3 +-- > >> 1 file changed, 1 insertion(+), 2 deletions(-) > > > > This results in: > > @@ -1,11 +1,11 @@ > > - creation_time : 2012-06-20T20:58:31.000000Z > > - creation_time : 2012-06-20T20:58:31.000000Z > > - creation_time : 2012-06-20T20:58:31.000000Z > > + creation_time : 1946-06-20T20:58:31.000000Z > > + creation_time : 1946-06-20T20:58:31.000000Z > > + creation_time : 1946-06-20T20:58:31.000000Z > > > > Are you sure that 1946 is the correct creation date and not 2012 ? > > If you are referring to the file in ticket #1471, yes, 1946 is consistent > with what mediainfo shows for creation time. Obviously 1946 was not the > intended creation time, but that does not warrant us to break > files where 1946 is the *intended* creation time. Proper way to fix the > original issue would be to detect the device and software version which > produces the invalid files, and only apply the hack there. But I don't > think that is doable here, the file does not seem to contain any device or > software information. How about adding an option for it, like -unix_time? -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".