From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E3972455A1 for ; Thu, 6 Apr 2023 07:27:27 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 30C9468BD88; Thu, 6 Apr 2023 10:27:19 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id DA2FF68B838 for ; Thu, 6 Apr 2023 10:27:12 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 577242404EE for ; Thu, 6 Apr 2023 09:27:12 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id gc7vZdVrroPg for ; Thu, 6 Apr 2023 09:27:11 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id A65AB2404EC for ; Thu, 6 Apr 2023 09:27:11 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id A570F1601B2; Thu, 6 Apr 2023 09:27:10 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20230405223307.GA1164690@pb2> References: <20230402155801.GH1164690@pb2> <20230403100954.11563-1-anton@khirnov.net> <20230405223307.GA1164690@pb2> Mail-Followup-To: FFmpeg development discussions and patches Date: Thu, 06 Apr 2023 09:27:10 +0200 Message-ID: <168076603064.27013.3642933550609618951@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: make sure non-lavfi streams are closed on input EOF X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Michael Niedermayer (2023-04-06 00:33:07) > On Mon, Apr 03, 2023 at 12:09:54PM +0200, Anton Khirnov wrote: > > --- > > Should be fixed by adding this patch to the set, at any point. > > Also updated my ffmpeg_frame_size branch. > > --- > > fftools/ffmpeg.c | 1 + > > 1 file changed, 1 insertion(+) > > Ive tested ffmpeg_frame_size and there are a few cases that change their > output, but i failed to find one that by watching the output looked different > I saw no crashes, infinite loops or other anomalies Thanks you for testing, I'd be interested in looking at some of those changed cases, if the samples are available. While changes in some corner cases are possible, it'd be nice to make sure that nothing actually breaks. Otherwise I'm going to push the set soonish. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".