From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 87FA545CE0 for ; Mon, 3 Apr 2023 10:16:13 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5734468BE4F; Mon, 3 Apr 2023 13:16:11 +0300 (EEST) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id CE0C768BE11 for ; Mon, 3 Apr 2023 13:16:05 +0300 (EEST) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 91CD12404EE for ; Mon, 3 Apr 2023 12:16:05 +0200 (CEST) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id O4322YSfq9cI for ; Mon, 3 Apr 2023 12:16:05 +0200 (CEST) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 0B5892404EC for ; Mon, 3 Apr 2023 12:16:05 +0200 (CEST) Received: by lain.khirnov.net (Postfix, from userid 1000) id 0BFB41601B2; Mon, 3 Apr 2023 12:16:03 +0200 (CEST) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20230402190635.GJ3542@mariano> References: <20230330093809.22687-1-anton@khirnov.net> <20230402190635.GJ3542@mariano> Mail-Followup-To: FFmpeg development discussions and patches Date: Mon, 03 Apr 2023 12:16:03 +0200 Message-ID: <168051696301.27013.16263636797264840578@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 1/2] lavf: fall back to a more meaningful log instance name X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Stefano Sabatini (2023-04-02 21:06:35) > On date Thursday 2023-03-30 11:38:07 +0200, Anton Khirnov wrote: > > An uninitialized AVFormatContext instance with neither iformat nor > > oformat set will currently log as 'NULL', which is confusing and > > unhelpful. Print 'AVFormatContext' instead, which provides more > > information. > > > > This happens e.g. if choosing an output format fails in > > avformat_alloc_output_context2(). > > --- > > libavformat/options.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavformat/options.c b/libavformat/options.c > > index 22ad523b2d..e4a3aceed0 100644 > > --- a/libavformat/options.c > > +++ b/libavformat/options.c > > @@ -44,7 +44,7 @@ static const char* format_to_name(void* ptr) > > AVFormatContext* fc = (AVFormatContext*) ptr; > > if(fc->iformat) return fc->iformat->name; > > else if(fc->oformat) return fc->oformat->name; > > - else return "NULL"; > > + else return fc->av_class->class_name; > > } > > Do you have an example to show? Anyway LGTM. ./ffmpeg -i /tmp/s.mkv -f foobar -y /dev/null before: [NULL @ 0x5580377834c0] Requested output format 'foobar' is not a suitable output format after: [AVFormatContext @ 0x55fa15bb34c0] Requested output format 'foobar' is not a suitable output format -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".