From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 7930F41188 for ; Wed, 5 Jan 2022 00:37:24 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id AA67F68A0EA; Wed, 5 Jan 2022 02:37:21 +0200 (EET) Received: from out2.migadu.com (out2.migadu.com [188.165.223.204]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id D77D3689997 for ; Wed, 5 Jan 2022 02:37:14 +0200 (EET) Message-ID: <167a6b4e-8a14-5796-fc7f-2ceb801cce60@zanevaniperen.com> DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=zanevaniperen.com; s=key1; t=1641343034; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LJRJupuffNpmNV+n/fJLXKy45Ad6XFslmRv/MPtS0Q4=; b=h4b6qjkFnft4uG806J7K5eZsjCQP9dwj0iEpW2EjLI41YfXwTCUXqG/WfEJCnayxf6jEOo L3Z9k+eqvgnFsff1L1l0wbaz7LkbqzqeusT/sIKxvucyXlJGU0SKQ8UsvcC1MEgBcETgUs DQgI/gscY7t4lsDEFM4DwpVGsagIPQ+MTGR4w7oAaLaWjAr22a2iqJ5S5ON4t3GCji7sbW PY6RqE1ap+6W5h6E1HOxfL9ZkmQ2u+4xZZ1fvjcHVxj3G4rysBsydg0ugtmKq3rApW6A0a bHVFtx6xefZ9Ng09XLvo1Qy4kQsgAnzT3ax+a38uNJs+mKjdkU0U6gdKGPAOQQ== Date: Wed, 5 Jan 2022 10:37:08 +1000 MIME-Version: 1.0 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: <20220104061127.398-1-pal@sandflow.com> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Zane van Iperen In-Reply-To: <20220104061127.398-1-pal@sandflow.com> X-Migadu-Flow: FLOW_OUT X-Migadu-Auth-User: zanevaniperen.com Subject: Re: [FFmpeg-devel] [PATCH v1] avformat/imf: fix error CPL root element is absent X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Pierre-Anthony Lemieux Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 4/1/22 16:11, pal@sandflow.com wrote: > cpl_element = xmlDocGetRootElement(doc); > - if (xmlStrcmp(cpl_element->name, "CompositionPlaylist")) { > + if ((!cpl_element) || xmlStrcmp(cpl_element->name, "CompositionPlaylist")) { Nit: Extra set of parens around "!cpl_element". Otherwise, this lgtm, I'll apply and backport this soon with that change. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".