From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id BA2AF4323E for ; Wed, 25 May 2022 16:05:38 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 9D93A68B543; Wed, 25 May 2022 19:05:35 +0300 (EEST) Received: from btbn.de (btbn.de [136.243.74.85]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 34DBA68B45D for ; Wed, 25 May 2022 19:05:24 +0300 (EEST) Received: from [authenticated] by btbn.de (Postfix) with ESMTPSA id C17162B5EF4; Wed, 25 May 2022 18:05:22 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rothenpieler.org; s=mail; t=1653494722; bh=2cFLBlw4fGIsJPwA888neLJbulEv1yPB+k6N2+61cgs=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=BratFN0q9HY4g5RaexasavLrn/05ZDYblAOFidzdnRqBO3S2rzj7N4uJ2pbtp9B6x mtahipVdWIZJGcTZpFYk1YAJK7tDVPNOm7MaRsb5P5W2OQ4v93aeyKQhMS4/nvjJhf EkWub+Rz0hCEvSt+vBWsBKmyF58BsM9uehcnvIdyO+55jlXsHc1wG0uMEd0n4Cjla8 9vd9FwO82HZnIyts67FPKx71ot5UPYaegRjDnSBTdnburJRhrwJctxWtBZaW85vp09 JUOHvfEALq9aP7Mn/dwX4/duFjSzdBhnpoxOz1QJf+UYHGHof8JvZluZF92xC0YFUu qCR+1ckjbZH+g== Message-ID: <167a0f90-1d7e-1d42-85f7-5cc301faa17a@rothenpieler.org> Date: Wed, 25 May 2022 18:05:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.9.1 Content-Language: en-US To: FFmpeg development discussions and patches , Haihao Xiang References: <20220522121911.10993-1-haihao.xiang@intel.com> From: Timo Rothenpieler In-Reply-To: <20220522121911.10993-1-haihao.xiang@intel.com> Subject: Re: [FFmpeg-devel] [PATCH] qsv: add requirement for the mininal version of libmfx X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: Haihao Xiang Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset="us-ascii"; Format="flowed" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: On 22/05/2022 14:19, Haihao Xiang wrote: > libmfx 1.28 was released 3 years ago, it is easy to get a greater > version than 1.28. We may remove lots of compile-time checks if adding > the requirement for the minimal version in the configure script. > --- > configure | 7 +- > libavcodec/qsv.c | 24 -- > libavcodec/qsvenc.c | 471 +++++++++++++------------------------ > libavcodec/qsvenc.h | 51 +--- > libavcodec/qsvenc_h264.c | 6 - > libavcodec/qsvenc_hevc.c | 10 - > libavfilter/vf_scale_qsv.c | 13 +- > libavfilter/vf_vpp_qsv.c | 143 ++++++----- > libavutil/hwcontext_qsv.c | 2 - > 9 files changed, 249 insertions(+), 478 deletions(-) > > diff --git a/configure b/configure > index f115b21064..2337f0a8f2 100755 > --- a/configure > +++ b/configure > @@ -6566,8 +6566,11 @@ enabled liblensfun && require_pkg_config liblensfun lensfun lensfun.h lf_ > # Media SDK or Intel Media Server Studio, these don't come with > # pkg-config support. Instead, users should make sure that the build > # can find the libraries and headers through other means. > -enabled libmfx && { check_pkg_config libmfx libmfx "mfx/mfxvideo.h" MFXInit || > - { require libmfx "mfx/mfxvideo.h" MFXInit "-llibmfx $advapi32_extralibs" && warn "using libmfx without pkg-config"; } } > +enabled libmfx && { check_pkg_config libmfx "mfx >= 1.28" "mfx/mfxvideo.h" MFXInit || > + { require libmfx "mfx/mfxvideo.h mfx/mfxdefs.h" MFXInit "-llibmfx $advapi32_extralibs" && This broke build with mfx_dispatch. Before this, it checked for libmfx.pc. Now it checks for mfx.pc, which is not installed by it. Which of those is correct? It should definitely not drop support for libmfx.pc, which was checked before this. _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".