From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] lavf: return AVERROR_EOF rather than EIO on EOF
Date: Mon, 27 Mar 2023 21:22:38 +0200
Message-ID: <167994495800.27013.9276725108824778318@lain.khirnov.net> (raw)
In-Reply-To: <eff4db88-4ea7-e790-cd50-7757d3c0ec65@passwd.hu>
Quoting Marton Balint (2023-03-27 21:08:54)
>
>
> On Mon, 27 Mar 2023, Marton Balint wrote:
>
> >
> >
> > On Mon, 27 Mar 2023, Anton Khirnov wrote:
> >
> >> ---
> >> libavformat/anm.c | 2 +-
> >> libavformat/dauddec.c | 2 +-
> >> libavformat/filmstripdec.c | 2 +-
> >> libavformat/idroqdec.c | 2 +-
> >> libavformat/sol.c | 3 ++-
> >> libavformat/vc1test.c | 2 +-
> >> 6 files changed, 7 insertions(+), 6 deletions(-)
> >
> > Aren't these supposed to return AVERROR_INVALIDDATA? Beacuse these are most
> > likely premature EOF-s when the file is truncated.
>
> Disregard my comment, I can see now that these are all in the
> beginning of read_packet().
Yeah, I picked just those where it was clear that it's an actual EOF.
There's a bunch of other EIO uses left that should probably be
INVALIDDATA, watches pelcome.
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-03-27 19:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-27 8:00 Anton Khirnov
2023-03-27 8:27 ` Paul B Mahol
2023-03-27 17:42 ` Marton Balint
2023-03-27 19:08 ` Marton Balint
2023-03-27 19:22 ` Anton Khirnov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167994495800.27013.9276725108824778318@lain.khirnov.net \
--to=anton@khirnov.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git