From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ffmpeg-devel-bounces@ffmpeg.org>
Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100])
	by master.gitmailbox.com (Postfix) with ESMTP id 250B545335
	for <ffmpegdev@gitmailbox.com>; Sun, 26 Mar 2023 09:21:06 +0000 (UTC)
Received: from [127.0.1.1] (localhost [127.0.0.1])
	by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DF87468C7F9;
	Sun, 26 Mar 2023 12:21:02 +0300 (EEST)
Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12])
 by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 80AF968C786
 for <ffmpeg-devel@ffmpeg.org>; Sun, 26 Mar 2023 12:20:56 +0300 (EEST)
Received: from localhost (localhost [IPv6:::1])
 by mail0.khirnov.net (Postfix) with ESMTP id 351812404EA
 for <ffmpeg-devel@ffmpeg.org>; Sun, 26 Mar 2023 11:20:56 +0200 (CEST)
Received: from mail0.khirnov.net ([IPv6:::1])
 by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024)
 with ESMTP id J6LUC3EMALmu for <ffmpeg-devel@ffmpeg.org>;
 Sun, 26 Mar 2023 11:20:55 +0200 (CEST)
Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256
 client-signature RSA-PSS (2048 bits) client-digest SHA256)
 (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK))
 by mail0.khirnov.net (Postfix) with ESMTPS id 57592240178
 for <ffmpeg-devel@ffmpeg.org>; Sun, 26 Mar 2023 11:20:55 +0200 (CEST)
Received: by lain.khirnov.net (Postfix, from userid 1000)
 id 133121601B2; Sun, 26 Mar 2023 11:20:55 +0200 (CEST)
From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
In-Reply-To: <fa0493d6-2165-d0de-de55-32b74f32736f@gmail.com>
References: <20230325191529.10578-1-anton@khirnov.net>
 <20230325191529.10578-9-anton@khirnov.net>
 <fa0493d6-2165-d0de-de55-32b74f32736f@gmail.com>
Mail-Followup-To: FFmpeg development discussions and patches
 <ffmpeg-devel@ffmpeg.org>
Date: Sun, 26 Mar 2023 11:20:55 +0200
Message-ID: <167982245505.27013.8633760073657743208@lain.khirnov.net>
User-Agent: alot/0.8.1
MIME-Version: 1.0
Subject: Re: [FFmpeg-devel] [PATCH 09/23] fftools/ffmpeg: stop handling
 AVMEDIA_TYPE_DATA in init_output_stream_encode()
X-BeenThere: ffmpeg-devel@ffmpeg.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: FFmpeg development discussions and patches <ffmpeg-devel.ffmpeg.org>
List-Unsubscribe: <https://ffmpeg.org/mailman/options/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=unsubscribe>
List-Archive: <https://ffmpeg.org/pipermail/ffmpeg-devel>
List-Post: <mailto:ffmpeg-devel@ffmpeg.org>
List-Help: <mailto:ffmpeg-devel-request@ffmpeg.org?subject=help>
List-Subscribe: <https://ffmpeg.org/mailman/listinfo/ffmpeg-devel>,
 <mailto:ffmpeg-devel-request@ffmpeg.org?subject=subscribe>
Reply-To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Errors-To: ffmpeg-devel-bounces@ffmpeg.org
Sender: "ffmpeg-devel" <ffmpeg-devel-bounces@ffmpeg.org>
Archived-At: <https://master.gitmailbox.com/ffmpegdev/167982245505.27013.8633760073657743208@lain.khirnov.net/>
List-Archive: <https://master.gitmailbox.com/ffmpegdev/>
List-Post: <mailto:ffmpegdev@gitmailbox.com>

Quoting James Almer (2023-03-25 20:43:46)
> On 3/25/2023 4:15 PM, Anton Khirnov wrote:
> > We do not support data encoders, so this should never be reached.
> 
> nit: The abort() below could be an av_assert0(0) instead. It's the only 
> abort() in the file, whereas av_assert0() is used a lot.

I did notice that too and I agree it should be changed, but not in this
patch.

-- 
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".