From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 82AFA45B94 for ; Fri, 24 Mar 2023 15:49:05 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 307D068C838; Fri, 24 Mar 2023 17:49:01 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 302FF68C751 for ; Fri, 24 Mar 2023 17:48:55 +0200 (EET) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id D08702404EA; Fri, 24 Mar 2023 16:48:54 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id GRBe0JLaFx66; Fri, 24 Mar 2023 16:48:53 +0100 (CET) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id D7C13240178; Fri, 24 Mar 2023 16:48:53 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id C3BFB1601B2; Fri, 24 Mar 2023 16:48:53 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20230324143916.755104-1-ullysses.a.eoff@intel.com> References: <20230324143916.755104-1-ullysses.a.eoff@intel.com> Mail-Followup-To: FFmpeg development discussions and patches , "U. Artie Eoff" Date: Fri, 24 Mar 2023 16:48:53 +0100 Message-ID: <167967293376.27013.5322805036723610095@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] lavfi: add hwdevice flag to hwupload/hwdownload/hwmap X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Cc: "U. Artie Eoff" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting U. Artie Eoff (2023-03-24 15:39:16) > This fixes a regression introduced by: > > commit 3f63685c3554aea7f72bab1fdbde440820816d37 > and > commit 632c34993195f716e9fa575af3de80d07fd50991 > > ...where command-lines like: > > ffmpeg -v verbose -hwaccel qsv \ > -init_hw_device qsv=qsv,child_device=/dev/dri/renderD128 \ > -hwaccel_output_format qsv -f rawvideo -pix_fmt yuv420p \ > -s:v 352x288 -r:v 25 -i input.yuv \ > -vf 'format=nv12,hwupload=extra_hw_frames=120' \ > -an -c:v h264_qsv -y output.h264 > > ffmpeg -v verbose -hwaccel qsv \ > -init_hw_device qsv=qsv,child_device=/dev/dri/renderD128 \ > -hwaccel_output_format qsv -f rawvideo -pix_fmt nv12 \ > -s:v 352x288 -r:v 25 -i input.yuv \ > -vf 'format=nv12|qsv,hwupload=extra_hw_frames=16,vpp_qsv=procamp=1:saturation=1.0,hwdownload,format=nv12' \ > -pix_fmt nv12 -f rawvideo -fps_mode passthrough -an -y output.yuv > > ...produced errors like: > > [hwupload @ 0x55b6171d0dc0] A hardware device reference is required to upload frames to. > [Parsed_hwupload_1 @ 0x55b6172053c0] Query format failed for 'Parsed_hwupload_1': Invalid argument > Error reinitializing filters! > Failed to inject frame into filter network: Invalid argument > > Signed-off-by: U. Artie Eoff > --- > libavfilter/vf_hwdownload.c | 1 + > libavfilter/vf_hwmap.c | 1 + > libavfilter/vf_hwupload.c | 1 + > 3 files changed, 3 insertions(+) > > diff --git a/libavfilter/vf_hwdownload.c b/libavfilter/vf_hwdownload.c > index 5ef23cb5d465..8e8044d5bc0a 100644 > --- a/libavfilter/vf_hwdownload.c > +++ b/libavfilter/vf_hwdownload.c > @@ -199,4 +199,5 @@ const AVFilter ff_vf_hwdownload = { > FILTER_OUTPUTS(hwdownload_outputs), > FILTER_QUERY_FUNC(hwdownload_query_formats), > .flags_internal = FF_FILTER_FLAG_HWFRAME_AWARE, > + .flags = AVFILTER_FLAG_HWDEVICE, I don't think hwdownload should be flagged, I don't see it using hw_device_ctx anywhere. Not that this flags is just for filters using that specific field, not all hardware filters in general. > }; > diff --git a/libavfilter/vf_hwmap.c b/libavfilter/vf_hwmap.c > index 2e03dfc1fec7..e246b22603b5 100644 > --- a/libavfilter/vf_hwmap.c > +++ b/libavfilter/vf_hwmap.c > @@ -427,4 +427,5 @@ const AVFilter ff_vf_hwmap = { > FILTER_OUTPUTS(hwmap_outputs), > FILTER_QUERY_FUNC(hwmap_query_formats), > .flags_internal = FF_FILTER_FLAG_HWFRAME_AWARE, > + .flags = AVFILTER_FLAG_HWDEVICE, > }; > diff --git a/libavfilter/vf_hwupload.c b/libavfilter/vf_hwupload.c > index dbc41734ccc3..ef61bb413757 100644 > --- a/libavfilter/vf_hwupload.c > +++ b/libavfilter/vf_hwupload.c > @@ -258,4 +258,5 @@ const AVFilter ff_vf_hwupload = { > FILTER_OUTPUTS(hwupload_outputs), > FILTER_QUERY_FUNC(hwupload_query_formats), > .flags_internal = FF_FILTER_FLAG_HWFRAME_AWARE, > + .flags = AVFILTER_FLAG_HWDEVICE, > }; Huh, wonder how I missed those. I do remember looking at them. In any case, thank you for finding these. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".