From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 94FDA45B7B for ; Fri, 24 Mar 2023 11:59:03 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 5ED6868C783; Fri, 24 Mar 2023 13:59:01 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 5329868C724 for ; Fri, 24 Mar 2023 13:58:55 +0200 (EET) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 176112404EA for ; Fri, 24 Mar 2023 12:58:55 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id uRangAo5PfkV for ; Fri, 24 Mar 2023 12:58:54 +0100 (CET) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 4C8F7240178 for ; Fri, 24 Mar 2023 12:58:54 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id 3A8CA1601B2; Fri, 24 Mar 2023 12:58:54 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <0d1d14c8-b41d-b88d-8a74-e11f7c455bae@gmail.com> References: <20230321170637.10907-6-jamrial@gmail.com> <20230321180001.65412-1-jamrial@gmail.com> <167965834125.27013.4504786416238930490@lain.khirnov.net> <0d1d14c8-b41d-b88d-8a74-e11f7c455bae@gmail.com> Mail-Followup-To: FFmpeg development discussions and patches Date: Fri, 24 Mar 2023 12:58:54 +0100 Message-ID: <167965913421.27013.10971877037446793810@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH v2 6/7] avformat/matroskaenc: support writing Dynamic HDR10+ packet side data X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting James Almer (2023-03-24 12:50:40) > On 3/24/2023 8:45 AM, Anton Khirnov wrote: > > Quoting James Almer (2023-03-21 19:00:01) > >> @@ -3095,6 +3153,12 @@ after_cues: > >> avio_seek(mkv->track.bc, track->blockadditionmapping_offset, SEEK_SET); > >> > >> put_ebml_uint(mkv->track.bc, MATROSKA_ID_TRACKMAXBLKADDID, track->max_blockaddid); > >> + if (track->max_blockaddid == 4) { // HDR10+ > > > > Maybe this magic 4 deserves a name too? > > Is has no name. See > https://www.matroska.org/technical/codec_specs.html#itu-t35-metadata > > It only defines a name for the BlockAddIDType, which i used, and > constricts the BlockAddIDValue to be used for it to 4. > It's not necessarily HDR10+ (i can remove that comment if it makes it > look like it should be named), it's potentially any ITU-T T35 payload of > which we only care about HDR10+, so i can't name it that. It's simply 4. MATROSKA_BLOCKADDITIONAL_ITUT35_VAL then? -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".