From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E94CF45794 for ; Fri, 24 Mar 2023 08:50:49 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id A59CA68C60D; Fri, 24 Mar 2023 10:50:45 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 4C9E568C3FF for ; Fri, 24 Mar 2023 10:50:39 +0200 (EET) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id 971FE2404EA for ; Fri, 24 Mar 2023 09:50:38 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id c5h3KYdI9-hX for ; Fri, 24 Mar 2023 09:50:38 +0100 (CET) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id 1BFB3240178 for ; Fri, 24 Mar 2023 09:50:38 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id F109B1601B2; Fri, 24 Mar 2023 09:50:37 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <20230324002540.3227-2-michael@niedermayer.cc> References: <20230324002540.3227-1-michael@niedermayer.cc> <20230324002540.3227-2-michael@niedermayer.cc> Mail-Followup-To: FFmpeg development discussions and patches Date: Fri, 24 Mar 2023 09:50:37 +0100 Message-ID: <167964783795.27013.16464276337894246810@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH 2/6] tools/enc_recon_frame_test: plane 0 height fix X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Michael Niedermayer (2023-03-24 01:25:36) > Signed-off-by: Michael Niedermayer > --- > tools/enc_recon_frame_test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/enc_recon_frame_test.c b/tools/enc_recon_frame_test.c > index 8f09ded47e..1ea2293ee7 100644 > --- a/tools/enc_recon_frame_test.c > +++ b/tools/enc_recon_frame_test.c > @@ -83,7 +83,7 @@ static int frame_hash(FrameChecksum **pc, size_t *nb_c, int64_t ts, > int linesize = av_image_get_linesize(frame->format, frame->width, p); > uint32_t checksum = 0; > > - for (int j = 0; j < frame->height >> shift_v; j++) { > + for (int j = 0; j < frame->height >> (shift_v *!!p); j++) { IIUC this won't work for alpha. Might as well make it completely generic. I'll send an updated version of the tool, thank you for reminding me. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".