From: Anton Khirnov <anton@khirnov.net>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH 2/6] tools/enc_recon_frame_test: plane 0 height fix
Date: Fri, 24 Mar 2023 09:50:37 +0100
Message-ID: <167964783795.27013.16464276337894246810@lain.khirnov.net> (raw)
In-Reply-To: <20230324002540.3227-2-michael@niedermayer.cc>
Quoting Michael Niedermayer (2023-03-24 01:25:36)
> Signed-off-by: Michael Niedermayer <michael@niedermayer.cc>
> ---
> tools/enc_recon_frame_test.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/enc_recon_frame_test.c b/tools/enc_recon_frame_test.c
> index 8f09ded47e..1ea2293ee7 100644
> --- a/tools/enc_recon_frame_test.c
> +++ b/tools/enc_recon_frame_test.c
> @@ -83,7 +83,7 @@ static int frame_hash(FrameChecksum **pc, size_t *nb_c, int64_t ts,
> int linesize = av_image_get_linesize(frame->format, frame->width, p);
> uint32_t checksum = 0;
>
> - for (int j = 0; j < frame->height >> shift_v; j++) {
> + for (int j = 0; j < frame->height >> (shift_v *!!p); j++) {
IIUC this won't work for alpha. Might as well make it completely
generic.
I'll send an updated version of the tool, thank you for reminding me.
--
Anton Khirnov
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
next prev parent reply other threads:[~2023-03-24 8:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 0:25 [FFmpeg-devel] [PATCH 1/6] avcodec/tests/snowenc: unbreak DWT tests Michael Niedermayer
2023-03-24 0:25 ` [FFmpeg-devel] [PATCH 2/6] tools/enc_recon_frame_test: plane 0 height fix Michael Niedermayer
2023-03-24 8:50 ` Anton Khirnov [this message]
2023-03-24 9:30 ` Michael Niedermayer
2023-03-24 0:25 ` [FFmpeg-devel] [PATCH 3/6] avcodec/snowenc: Fix visual weight calculation Michael Niedermayer
2023-03-25 20:38 ` Michael Niedermayer
2023-03-24 0:25 ` [FFmpeg-devel] [PATCH 4/6] avcodec/tests/snowenc: return a failure if DWT/IDWT mismatches Michael Niedermayer
2023-03-25 20:38 ` Michael Niedermayer
2023-03-24 0:25 ` [FFmpeg-devel] [PATCH 5/6] avcodec/tests/snowenc: Fix 2nd test Michael Niedermayer
2023-03-25 20:53 ` Michael Niedermayer
2023-03-24 0:25 ` [FFmpeg-devel] [PATCH 6/6] tests: Add fate-snowenc Michael Niedermayer
2023-03-25 20:37 ` [FFmpeg-devel] [PATCH 1/6] avcodec/tests/snowenc: unbreak DWT tests Michael Niedermayer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167964783795.27013.16464276337894246810@lain.khirnov.net \
--to=anton@khirnov.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git