From: Jyrki Vesterinen <jyrkive@nekonyansoft.com>
To: Anton Khirnov <anton@khirnov.net>,
FFmpeg development discussions and patches
<ffmpeg-devel@ffmpeg.org>
Subject: Re: [FFmpeg-devel] [PATCH] avcodec/vorbisdec: export skip_samples instead of dropping frames
Date: Wed, 22 Mar 2023 15:45:31 +0000
Message-ID: <1679499766079.3317642992.3597149340@nekonyansoft.com> (raw)
In-Reply-To: <1679078709650.3329536820.1508486353@nekonyansoft.com>
perjantai, 17. maaliskuuta 2023, klo 20.45 (+02:00), Jyrki Vesterinen
kirjoitti:
>
> perjantai, 17. maaliskuuta 2023, klo 20.38 (+02:00), Anton Khirnov
kirjoitti:
>
> > CCing the author of the commit that's being undone.
> > Jyrki, you should set AV_CODEC_FLAG2_SKIP_MANUAL in
> > AVCodecContext.flags2 to avoid lavc dropping any samples. Please let
us
> > know if this works for your case.
> >
> OK, I'll test it next week.
>
I have verified that with your patch applied and when the client code
passes AV_CODEC_FLAG2_SKIP_MANUAL, our use case works correctly and audio
samples aren't being skipped. Thank you!
--
Jyrki Vesterinen
Programmer
NekoNyan Ltd
_______________________________________________
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".
prev parent reply other threads:[~2023-03-22 15:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-16 17:09 James Almer
2023-03-17 18:38 ` Anton Khirnov
2023-03-17 18:45 ` Jyrki Vesterinen
2023-03-22 15:45 ` Jyrki Vesterinen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1679499766079.3317642992.3597149340@nekonyansoft.com \
--to=jyrkive@nekonyansoft.com \
--cc=anton@khirnov.net \
--cc=ffmpeg-devel@ffmpeg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror https://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ https://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git