From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id 4358145AA1 for ; Wed, 15 Mar 2023 15:12:48 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id DE34668BE93; Wed, 15 Mar 2023 17:12:46 +0200 (EET) Received: from mail0.khirnov.net (red.khirnov.net [176.97.15.12]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id 013A368BE73 for ; Wed, 15 Mar 2023 17:12:40 +0200 (EET) Received: from localhost (localhost [IPv6:::1]) by mail0.khirnov.net (Postfix) with ESMTP id BC1882404EA for ; Wed, 15 Mar 2023 16:12:40 +0100 (CET) Received: from mail0.khirnov.net ([IPv6:::1]) by localhost (mail0.khirnov.net [IPv6:::1]) (amavisd-new, port 10024) with ESMTP id hd406aaKpS_V for ; Wed, 15 Mar 2023 16:12:40 +0100 (CET) Received: from lain.khirnov.net (lain.khirnov.net [IPv6:2001:67c:1138:4306::3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "lain.khirnov.net", Issuer "smtp.khirnov.net SMTP CA" (verified OK)) by mail0.khirnov.net (Postfix) with ESMTPS id DEC85240178 for ; Wed, 15 Mar 2023 16:12:39 +0100 (CET) Received: by lain.khirnov.net (Postfix, from userid 1000) id D16291601B2; Wed, 15 Mar 2023 16:12:39 +0100 (CET) From: Anton Khirnov To: FFmpeg development discussions and patches In-Reply-To: <83f63316-ee67-16ea-d58d-d513ead8a0d3@noa-archive.com> References: <20230315144525.4140-1-anton@khirnov.net> <83f63316-ee67-16ea-d58d-d513ead8a0d3@noa-archive.com> Mail-Followup-To: FFmpeg development discussions and patches Date: Wed, 15 Mar 2023 16:12:39 +0100 Message-ID: <167889315983.10789.3776378389299295658@lain.khirnov.net> User-Agent: alot/0.8.1 MIME-Version: 1.0 Subject: Re: [FFmpeg-devel] [PATCH] lavc/libx265: flag as experimental X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: Quoting Tobias Rapp (2023-03-15 16:00:04) > On 15/03/2023 15:45, Anton Khirnov wrote: > > > This encoder leaks and overreads, as can be seen e.g. by running an > > encode under valgrind with default encoder parameters. This was known > > upstream since at least 2019 (e.g. bitbucket issue #482) but never fixed > > until now. > > > > Since upstream does not seem to practice basic code hygiene, make sure > > people do not use this encoder without knowing what they are getting > > into. > > --- > > libavcodec/libx265.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/libavcodec/libx265.c b/libavcodec/libx265.c > > index 420d0953af..d4511251a5 100644 > > --- a/libavcodec/libx265.c > > +++ b/libavcodec/libx265.c > > @@ -895,7 +895,8 @@ FFCodec ff_libx265_encoder = { > > .p.id = AV_CODEC_ID_HEVC, > > .p.capabilities = AV_CODEC_CAP_DR1 | AV_CODEC_CAP_DELAY | > > AV_CODEC_CAP_OTHER_THREADS | > > - AV_CODEC_CAP_ENCODER_REORDERED_OPAQUE, > > + AV_CODEC_CAP_ENCODER_REORDERED_OPAQUE | > > + AV_CODEC_CAP_EXPERIMENTAL, > > .p.priv_class = &class, > > .p.wrapper_name = "libx265", > > .init = libx265_encode_init, > > My understanding of this flag for encoders is that it indicates some > possible experimental/non-standard bitstream features contained in > output data, not that the implementation itself is considered sub-par. Our internal aac encoder used to be marked as experimental. vorbis and opus still are. So it's clearly about the implementation quality rather than standard compliance. -- Anton Khirnov _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".